refactor(system_mrm_emergency_stop_operator): rework parameters #5734

karishma1911 · 2023-11-30T14:09:45Z

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the mrm_comfortable_stop_operator

Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
create schema

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

stale · 2024-03-19T18:59:58Z

This pull request has been automatically marked as stale because it has not had recent activity.

idorobotics · 2024-05-24T09:50:32Z

@mkuri @TomohitoAndo please urgently review.

…utowarefoundation#5816) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

…ndation#5744) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

…5820) * refactor(side_shift): separate side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…warefoundation#5689) fix(avoidance): output invalid avoidance path Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions <github-actions@github.com>

…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

…oid exceeding max voxel size (autowarefoundation#5824)

…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

…arefoundation#5819) * fix(traffic_light): stop if the traffic light signal timed out Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(traffic_light): fix README format Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

…c_time/elapsed_time, tentative objects (autowarefoundation#5762) * enable debugger in tracker Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix uninitialized class variable Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: separate debugger class for simplification Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

…utowarefoundation#5830) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

doc(intersection): add image Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

…atus (autowarefoundation#5682) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* update cmakelists Signed-off-by: N-Eiki <naganagaeichan@gmail.com> * add z filter param Signed-off-by: N-Eiki <naganagaeichan@gmail.com> * isWithin func private -> public Signed-off-by: N-Eiki <naganagaeichan@gmail.com> * add test code Signed-off-by: N-Eiki <naganagaeichan@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: N-Eiki <naganagaeichan@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>

…ion#5836) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

…oundation#5832) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…n#5848) Changed landmark_manager to a shared library Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

…ar topic (autowarefoundation#5781) rename lidar topic Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>

* update api maintainers Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

…n#6100) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…utowarefoundation#6099) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…refoundation#6087) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

…affic light id map every callback (autowarefoundation#6061) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

…compensation (autowarefoundation#6080) Signed-off-by: scepter914 <scepter914@gmail.com>

* fix(pointpainting): fix param path declaration Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove pointpainting_model_name Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert: revert unnecessary change Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp>

* docs(crosswalk): update the document Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix the spell Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

…usion detection and 1st/2nd attention lane (autowarefoundation#6047) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

…utowarefoundation#5635) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> remove non-support Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> fix link Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> add yaml Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> please check readme

Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions <github-actions@github.com>

…on#6103) * Visualize the footprint from start_pose to end_pose along the path Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

…data structure (autowarefoundation#6101) * Add data_structs.hpp and update include paths * Refactor start planner debug data structure * Update debug_data variable name in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…arefoundation#6055) Refactor lane departure check in ShiftPullOut::plan() Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

…pty (autowarefoundation#6104) * check if p_safety_slow is empty Signed-off-by: beyza <bnk@leodrive.ai> * style(pre-commit): autofix --------- Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…utowarefoundation#6091) * feat!: replace use_pointcloud_container Signed-off-by: kminoda <koji.minoda@tier4.jp> * feat: remove from planning Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: fix to remove all use_pointcloud_container Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert: revert change in planning.launch Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert: revert rename of use_pointcloud_container Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: fix tier4_perception_launch to enable use_pointcloud_contaienr Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: fix unnecessary change Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: fix unnecessary change Signed-off-by: kminoda <koji.minoda@tier4.jp> * refactor: remove trailing whitespace Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert other changes in perception Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert change in readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * feat: move glog to pointcloud_container.launch.py * revert: revert glog porting Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix: fix pre-commit Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…ion (autowarefoundation#6072) * add acc filtering and decaying acc to model Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * fixed compilation problem, acc is used to predict search_dist Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * Use an equivalent velocity to calculate paths Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * change decaying factor to T/4 Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * coment out cerr for evaluation Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * simplify code Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * comments Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add missing constant to decaying acc model Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * Use an equivalent velocity to calculate paths Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add missing constant to decaying acc model Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * Implement lanelet speed limit for acc consideration Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add option to activate on and off acceleration feature Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add params Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add params Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * delete unused class Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update docs Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete comments Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * fix comments Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * update comments, refactor code Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * remove unused line Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> --------- Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

…rplai/autoware.universe into mrm-emergency-stop-operator

idorobotics · 2024-06-02T15:19:45Z

@mkuri @TomohitoAndo could you urgently review this PR?

TomohitoAndo · 2024-07-18T23:47:37Z

@karishma1911 @idorobotics
Sorry for the late response 🙇
It seems this PR has many unnecessary commits, so could you please rebase the branch?

idorobotics · 2024-07-19T03:58:56Z

@karishma1911 @idorobotics
Sorry for the late response 🙇
It seems this PR has many unnecessary commits, so could you please rebase the branch?

@oguzkaganozt

stale · 2024-09-17T07:49:14Z

This pull request has been automatically marked as stale because it has not had recent activity.

mitsudome-r · 2024-12-17T08:42:21Z

Since since no one is reviewing, I will review the PR as a maintainer.

mitsudome-r · 2024-12-17T08:42:43Z

Since there is an issue with commit log, I will recreate the PR.

karishma1911 requested a review from mkuri as a code owner November 30, 2023 14:09

github-actions bot added the component:system System design and integration. (auto-assigned) label Nov 30, 2023

karishma1911 force-pushed the mrm-emergency-stop-operator branch 2 times, most recently from 079327e to f87cc89 Compare November 30, 2023 14:12

karishma1911 requested a review from TomohitoAndo as a code owner December 6, 2023 11:24

karishma1911 force-pushed the mrm-emergency-stop-operator branch from d51f3a7 to 3cbb7cb Compare December 6, 2023 11:24

stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 19, 2024

isamu-takagi and others added 21 commits May 28, 2024 17:09

feat(system_diagnostic_graph): support config override and add tests (a…

e18fae8

…utowarefoundation#5816) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

fix(autoware_auto_msgs_adapter): fix predicted path test (autowarefou…

0a6e8c5

…ndation#5744) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

fix(avoidance): output invalid avoidance path with unsafe state (auto…

494e078

…warefoundation#5689) fix(avoidance): output invalid avoidance path Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

chore: update CODEOWNERS (autowarefoundation#5811)

12d9952

Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions <github-actions@github.com>

fix(localization_util): fixed rejection criteria of SmartPoseBuffer::…

7c18a88

…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

fix(lidar_centerpoint,image_projection_based_fusion): add guard to av…

726c432

…oid exceeding max voxel size (autowarefoundation#5824)

feat(obstacle_cruise_planner): add jerk and acc limits for slow-down (a…

aafb79e

…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

refactor(surround_obstacle_checker): boost::optional to std:optional (a…

55de4f7

…utowarefoundation#5830) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

docs(intersection): add image (autowarefoundation#5833)

add4829

doc(intersection): add image Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

fix(avoidance): reset output path when the module transits success st…

ccb96f6

…atus (autowarefoundation#5682) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

refactor(motion_utils): apply clang-tidy result (autowarefoundation#5829

e349ffb

) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

fix(avoidance): fix missing parent ids (autowarefoundation#5838)

dfea3c4

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

fix(goal_planner): fix checkOriginalGoalIsInShoulder (autowarefoundat…

cc864f2

…ion#5836) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

refactor(occlusion_spot): boost::optional to std::optional (autowaref…

510c1b3

…oundation#5832) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

fix(planning): fix typo (autowarefoundation#5841)

ed7916f

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

fix(landmark_manager): changed to a shared library (autowarefoundatio…

42f7441

…n#5848) Changed landmark_manager to a shared library Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

refactor(localization_launch, ground_segmentation_launch): rename lid…

33ec8ce

…ar topic (autowarefoundation#5781) rename lidar topic Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>

isamu-takagi and others added 19 commits May 28, 2024 17:09

chore: update api package maintainers (autowarefoundation#6086)

97c3337

* update api maintainers Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

feat(rviz_plugin): add string visualization plugin (autowarefoundatio…

2420dfb

…n#6100) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

feat(behavior_path_planner): output manager internal state as topic (a…

ae2f0ba

…utowarefoundation#6099) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

refactor(goal_planner): remove duplicated execution condition (autowa…

daad3a6

…refoundation#6087) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

fix(behavior_velocity_planner, behavior_path_planner): refresh raw tr…

398e6f9

…affic light id map every callback (autowarefoundation#6061) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

fix(radar_tracks_msgs_converter): change default parameter for twist …

4087e16

…compensation (autowarefoundation#6080) Signed-off-by: scepter914 <scepter914@gmail.com>

feat(intersection): more precise pass judge handling considering occl…

3ebffc3

…usion detection and 1st/2nd attention lane (autowarefoundation#6047) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

feat(blind_spot): consider opposite adjacent lane for wrong vehicles (a…

2d0abd1

…utowarefoundation#5635) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

chore: update CODEOWNERS (autowarefoundation#6038)

319990d

Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions <github-actions@github.com>

refactor(start_planner): visualize shifting section (autowarefoundati…

2877cbf

…on#6103) * Visualize the footprint from start_pose to end_pose along the path Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

fix(start_planner): expand lane departure check for shift path (autow…

c831fcf

…arefoundation#6055) Refactor lane departure check in ShiftPullOut::plan() Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

Merge branch 'mrm-emergency-stop-operator' of https://github.com/Inte…

17c148b

…rplai/autoware.universe into mrm-emergency-stop-operator

stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 28, 2024

Merge branch 'main' into mrm-emergency-stop-operator

3527256

stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Sep 17, 2024

mitsudome-r self-assigned this Dec 17, 2024

stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(system_mrm_emergency_stop_operator): rework parameters #5734

refactor(system_mrm_emergency_stop_operator): rework parameters #5734

karishma1911 commented Nov 30, 2023 •

edited

Loading

stale bot commented Mar 19, 2024

idorobotics commented May 24, 2024

idorobotics commented Jun 2, 2024

TomohitoAndo commented Jul 18, 2024

idorobotics commented Jul 19, 2024

stale bot commented Sep 17, 2024

mitsudome-r commented Dec 17, 2024

mitsudome-r commented Dec 17, 2024

refactor(system_mrm_emergency_stop_operator): rework parameters #5734

Are you sure you want to change the base?

refactor(system_mrm_emergency_stop_operator): rework parameters #5734

Conversation

karishma1911 commented Nov 30, 2023 • edited Loading

Description

Tests performed

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

stale bot commented Mar 19, 2024

idorobotics commented May 24, 2024

idorobotics commented Jun 2, 2024

TomohitoAndo commented Jul 18, 2024

idorobotics commented Jul 19, 2024

stale bot commented Sep 17, 2024

mitsudome-r commented Dec 17, 2024

mitsudome-r commented Dec 17, 2024

karishma1911 commented Nov 30, 2023 •

edited

Loading