Skip to content

Releases: rh-hideout/pokeemerald-expansion

Version 1.10.0

01 Dec 20:32
7f494f8
Compare
Choose a tag to compare
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.10.0`.

🌋 REFACTORS 🌋

📜 = Uses a migration script.

  • Changes Evolution methods to Enums by @AlexOn1ine in #4977
  • Turn item hold effects into an enum by @Bassoonian in #5498
  • Change GET_MOVE_TYPE to a function by @AlexOn1ine in #5090
  • Created COMPOUND_STRINGs for default player names by @fdeblasio in #5037
  • Removed agbcc by @mrgriffin in #4994
  • Refactor Frontier Brains by @fdeblasio in #5027
  • Removed all instances of gBitTable[x] by @hedara90 in #5123
  • Made BuildColorMaps redundant by using static tables by @pkmnsnfrn, @Deokishisu and @ShinyDragonHunter in #5289
  • Removed FRONTIER_BRAIN_SPRITES and updated TRAINER_SPRITE, TRAINER_BACK_SPRITE, and TRAINER_CLASS by @fdeblasio in #5166
  • Added ShouldSwitch result to AiLogicData by @Pawkkie and @AlexOn1ine had the idea! in #5440
  • Switch AI refactor + considers free switches by @Pawkkie in #5379
  • Refactor ShouldSwitchIfAllBadMoves by @Pawkkie in #5452
  • Updated Wring Out effects to match Eruption effects by @AsparagusEduardo in #5549
    • Changed Wring Out/Crush Grip/Hard Press to use power instead of argument to determine its max power, just like how Eruption/Water Spout/Dragon Energy do it.
    • Also:
      • Renamed EFFECT_VARY_POWER_BASED_ON_HP to EFFECT_POWER_BASED_ON_TARGET_HP
      • Renamed EFFECT_ERUPTION to EFFECT_POWER_BASED_ON_USER_HP
  • Update battle messages to Gen 5+ standards by @kittenchilly in #3240
  • Should switch refactor to facilitate switch prediction by @Pawkkie in #5466
  • Unwind TRAINER_CLASS macro by @SBird1337 in #5611
  • Refactors Absorb to use Moveend by @AlexOn1ine in #5670
    • For new absorbing moves an argument should be added in moves_info.h
  • Changes name of B_SCR_NAME_WITH_PREFIX by @AlexOn1ine in #5675

🧬 General 🧬

Added

  • Added performance counter by @hedara90 and @SBird1337 provided the actual code in #5284
  • Added debug build target by @u8-Salem in #4817
  • Added AUTO_SCROLL_TEXT and NUM_FRAMES_AUTO_SCROLL_DELAY by @pkmnsnfrn and Mashanny in #5054
  • Adds SAVE_TYPE_ERROR_SCREEN by @pkmnsnfrn and Anon822 in #5188
  • Move Relearner and Renaming From Summary Screen by @ravepossum in #5513
  • Automatic Line Breaks, somewhat even lines by @hedara90 and @AsparagusEduardo in #5689
    • Automatically insert line breaks into a string with BreakStringAutomatic.
    • This function does not modify strings with existing line breaks.
    • Remove existing line breaks from a string with StripLineBreaks.

Changed

🗺️ Overworld 🗺️

Added

Changed

Fixed

🐉 Pokémon 🐉

Added

Changed

  • Made perfect IV count into a granular setting by @AsparagusEduardo in #5115
  • Updated species defines by @pkmnsnfrn and @mrgriffin in #5075
  • Added support for overworld sprite gender differences + add all the sprites by @kittenchilly in #5394
  • Renamed folders and symbols to match species defines by @AsparagusEduardo in #5581
    • Burmy and Wormadam footprints were in a plant subfolder. They have been moved to the species root folder
    • Paldean Wooper's subfolder was named wooper_paldean instead of just paldean. This has been corrected.
    • Zen Mode Galarian Darmanitan's folder was located in darmanitan/galarian/zen_mode. This has been corrected to darmanitan/galar_zen, alongside Galarian Standard Mode's darmanitan/galar_standard.
    • Also updated Ogerpon's folders similarly.
    • Renamed SPECIES_PIKACHU_PARTNER_CAP to SPECIES_PIKACHU_PARTNER.
  • Changing EVO_NONE from 0xFFFE to 0 by @GhoulMage in #5547
    • There could be a case f...
Read more

Version 1.9.4

01 Dec 20:07
2e65627
Compare
Choose a tag to compare
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.9.4`.

🌋 IMPORTANT 🌋

  • This update integrates pret's latest Makefile changes, which rearranges the entire file in order to speed up compilation times overall. If you did any changes to it (such as installing Poryscript) and are having issues resolving the conflicts, keep expansion's version of Makefile and reapply your changes afterwards.

🧬 General 🧬

Fixed

  • Fixed alignment errors in EWRAM_INIT and friends when using u8, u16, etc. by @aronson in #5512
  • Update test LD script to respect 4 byte data section alignment by @aronson in #5517
  • Fixed Missing string_util.h include in mini_printf.c by @mrgriffin in #5572
  • Fixed unnecessary dependency scanning for test build and test rom names by @ravepossum in #5594
  • Fixed makefile: dependencies for map_group_count.h by @SBird1337 in #5648
    • Fixes an issue that caused the build to fail on updates to src/debug.c due to mismatched dependency.

🗺️ Overworld 🗺️

Changed

Fixed

  • Fixed Berry mutations always generating a Persim Berry by @Bassoonian in #5504

🐉 Pokémon 🐉

Changed

  • Changing EVO_NONE from 0xFFFE to 0 by @GhoulMage in #5547
    • There could be a case for out of bounds errors if arrays or iterations are happening where you're using + 1 or - 1, as EVO_FRIENDSHIP used to be the first index although it started with 1.
  • PokeCommunity sprites batch (October) by @kittenchilly in #5655
  • Followers sprite fixes by @Cafeei in #5669
  • Follower fixes, Melmetal, Patrat, Woobat by @hedara90 in #5685
  • Fixed Farfetch'd overworld sprite by @hedara90 in #5711

Fixed

⚔️ Battle General ⚔️

Changed

Fixed

  • Fixed Shiny Pokemon not being shiny after transforming with a gimmick by @hedara90 in #5573
  • Handle showdowns apostrophe the same way as ASCII apostrophe by @cawtds in #5712
  • Fixes Misty Terrain displaying wrong message by @AlexOn1ine in #5742
  • Fixes Dynamax dynamic move type by @AlexOn1ine in #5739

🤹 Moves 🤹

Changed

  • Fixed damage calc modifiers by @AlexOn1ine in #5604
  • Updated ability popups for Skill Swap, Mummy/Lingering Aroma, Worry Seed, Simple Beam, fix Doodle/Role Play bugs by @PhallenTree in #5493

Fixed

🎭 Abilities 🎭

Changed

Fixed

🧶 Items 🧶

Changed

Fixed

🤖 Battle AI 🤖

Fixed

🧹 Other Cleanup 🧹

Read more

Version 1.9.3

08 Oct 17:48
a76f7fe
Compare
Choose a tag to compare
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.9.3`.

🌋 REFACTORS 🌋

📜 = Uses a migration script.

  • Converted settotemboost command to callnative in #5418
  • Removed unused RESOURCE_FLAG_TRACED in #5430
  • Changed MOVEEND_ defines to an enum in #5449

✨ Feature Branches ✨

merrp/aarant's Followers

Fixed

  • Fixed Expansion-exclusive issue that caused trainers to not play their "pointing" animation when Followers were out during battle intro by @kittenchilly in #5406

⚔️ Battle General ⚔️

Changed

  • Improved Mega evolution animation to make it a little smoother by @kleenxfeu in #4816

Fixed

  • Fixed affection check for exp multiplier by @Bassoonian in #5421
  • Fixed multiple Primal Reversions not occurring if multiple battlers fainted on the previous turn by @PhallenTree in #5430

🤹 Moves 🤹

Added

  • Added missing B_AFTER_YOU_TURN_ORDER config by @PhallenTree in #5400
    • Gen 5-7: After You fails if the order remains the same after using After You.
    • Gen 8+: After You no longer fails if the turn order remains the same after using After You.
  • Added missing B_QUASH_TURN_ORDER config by @PhallenTree in #5400
    • Gen 5-7: If multiple Pokémon are affected by Quash, they move in the order they were affected by Quash.
    • Gen 8+: If multiple Pokémon are affected by Quash, they now move fastest to slowest.
  • Added missing updated B_UPDATED_CONVERSION_2 by @wiz1989 in #5453
    • Gens 2-4: Conversion 2 changes the user's type to a type that is resistant/immune to the last move the user was hit by.
    • Gen 5+: Conversion 2 changes the user's type to a type that resists the last move used by the selected target.

Fixed

  • Fixed Scale Shot corrupting the move used on the next turn by @AlexOn1ine in #5397
  • Fixed Growth's description not being updated based on B_GROWTH_STAT_RAISE by @nescioquid in #5398
  • Fixed Quash not updating the battlers' actions correctly by @PhallenTree in #5400
  • Fixed Snatched Swallow not recovering HP if the Snatcher is not under the effect of Stockpile (should still heal) by @PhallenTree in #5430
  • Fixed Counter users being damaged by Spiky Shield by @AlexOn1ine in #5402
  • Fixed Electrified Dragon Darts not correctly avoiding targets with ability immunity (Volt Absorb, Motor Drive) by @PhallenTree in #5430
  • Fixed Trace not activating a switch-in ability it traces (eg. Intimidate) by @PhallenTree in #5430
    • Removed unused RESOURCE_FLAG_TRACED.
  • Fixed recoil damage not triggering healing berries by @AlexOn1ine in #5449
    • Also changed MOVEEND_ defines to an enum.

🎭 Abilities 🎭

Fixed

  • Fixed Dancer activating even if the dance move is stolen by Snatch by @PhallenTree in #5430
  • Fixed Ability popup when multiple Pokémon faint at the same time by @PhallenTree in #5430
  • Multiple ability fixes by @PhallenTree in #5447
    • Fixed Protosynthesis/Quark Drive sometimes not activating ability popup despite still gaining the boost as they should.
    • Fixed Protosynthesis/Quark Drive activating on Transformed battlers.
    • Fixed Protosynthesis activating despite Cloud Nine being present on the field.
    • Fixed Quark Drive not activating if the battler is not grounded.
    • Fixed Protosynthesis/Quark Drive/Beast Boost stat raise priority when multiple stats are tied for the highest one.
      • Before: Attack, Defense, Speed, Special Attack, Special Defense.
      • After: Attack, Defense, Special Attack, Special Defense, Speed.

🧶 Items 🧶

Fixed

🤖 Battle AI 🤖

Fixed

  • Fixed Trick/Switcheroo giving AI score even if the opponent has no held item by @kittenchilly in #5412
  • Various AI fixes in AI_CalcMoveEffectScore by @ghoulslash in #5474
    • Missing break from EFFECT_ABSORB switch case.
    • Using last used move for Mirror Move instead of predicted move.

🧹 Other Cleanup 🧹

Changed

Fixed

🧪 Test Runner 🧪

Added

Changed

  • Improved Tangling Hair test to make sure that chained effects do not overwrite relevant battler IDs by @ghoulslash in #5423
  • Improved Full Heal item tests by @kittenchilly in #5444

Fixed

New Contributors

Full Changelog: expansion/1.9.2...expansion/1.9.3

Version 1.9.2

16 Sep 15:13
889a02d
Compare
Choose a tag to compare
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.9.2`.

🌋 REFACTORS 🌋

📜 = Uses a migration script.

  • Remove unused BattleScript_WindPowerActivatesEnd2 in #5257
  • Refactored in-battle disobedience to fix bug in #5245

💥 Hardlock/Softlock/Crash/Compiling fixes 💥

  • Fixed hardlock when Hyperspace Fury is used by Hoopa Unbound by @AlexOn1ine in #5237
  • Fixed compile error when OW_POKEMON_OBJECT_EVENTS is TRUE but P_HISUIAN_FORMS is FALSE around Basculin by @hjk321 in #5256
  • Fixed hardlock when the AI cannot choose moves due to its opponent having Wonder Guard by @Pawkkie and Wiz in #5317
  • Fixed multiple Pledge move hardlocks
    • Fixed potential hardlock when attempting to use Pledge moves on the same turn that the user would wake up by @PhallenTree in #5330
    • Fixed hardlock when the opponent's combo doesn't happen when cancelled by sleep by @hedara90 and @PhallenTree in #5339
    • Fixes hardlock when the opponent's combo doesn't happen when cancelled by freeze by @PhallenTree in #5340
    • Fixed hardlock when the opponent's combo doesn't happen when cancelled by Powder by @hedara90 in #5341

🧬 General 🧬

Fixed

  • Fixed loading into the wrong version of a map after saving in areas with multiple layouts by @hedara90 in #5347

🐉 Pokémon 🐉

Added

Changed

Fixed

  • Reenabled unused female Indeedee overworld sprite by @Cafeei in #5285
  • Fixed G-Max Corviknight and Centiskorch's expanded names by @PhallenTree in #5296
  • Fixed G-Max Cinderace back sprite by @hedara90 in #5295
  • Fixed Shiny Mothim' by @Cafeei in #5333
  • Fixed multiple battle sprite issues by @kittenchilly in #5142
    • Sprite issues:
      • Bombirdier, Mega Absol/Aerodactyl/Latias/Latios/Salamence, Orthworm and Veluza.
    • Shiny issues:
      • Bombirdier, Kilowattrel, Landorus, Magearna, Mega Diancie/Medicham, Galarian Ponyta, Shroodle, Spidops and Wattrel.
  • Fixed multiple overworld Pokémon sprites - Part 1 by @Cafeei in #5241
    • "Blinking pixels":
      • Dwebble, Krookodile, Servine, Throh and Vulpix.
    • Shiny Palettes
      • Crustle, Excadrill, Lillipup, Serperior, Servine, Sigilyph, Swoobat, Tranquil and Venipede.
    • Misc fixes:
      • Archen, Basculin, Blitzle, Crustle, Escavalier, Krokorok, Krookodile, Sawsbuck, secondary, Serperior, Snivy, Throh, Woobat, Zebstrika
  • Fixed multiple overworld Pokémon sprites - Part 2 by @Cafeei in #5333
    • Palette Fixes:
      • Shiny Riolu/Snover, Oshawott, Kabutops, Shieldon, Kingler and Groudon.
    • Fixed "Blinking pixels":
      • Abomasnow, Aggron, Alakazam, Ariados, Articuno, Azumarill, Barboach, Bayleef, Bibarel, Blastoise, Celebi, Charmeleon, Cherrim, Chinchou, Cloyster, Corphish, Corsola, Crawdaunt, Cubone, Dewott, Doduo, Dusknoir, Electabuzz, Espeon, Exeggcute, Farfetch'd, Feraligatr, Flaafy, Flareon, Floatzel, Furret, Gastly, Girafarig, Giratina, Gligar, Gloom, Golbat, Grumpig, Hariyama, Heatran (just reduced), Hoppip, Jolteon, Jumpluff, Kricketot, Larvitar, Leafeon, Lileep, Lumineon, Luxio, Luxray, Machamp, Magneton, Mantine, Mantyke, Marowak, Meowth, Mesprit, Mew, Mewtwo, Mime Jr, Moltres, Numel, Oshawott, Phione, Pinsir, Politoed, Porygon-Z, Probopass, Quilava, Qwilfish, Rampardos, Rapidash, Regirock, Sceptile, Scizor, Seel, Shieldon, Shiftry, Slowking, Smoochum, Sneasel, Spheal, Steelix, Sudowoodo, Suicune, Swellow, Swinub, Tentacruel, Togekiss, Togepi, Vaporeon, Vibrava, Wartortle, Wooper, Yanma, Yanma, Yanmega, Zangoose, Zapdos, Zubat
    • Misc. Sprite Fixes: Dewott, Misdreavus, Oshawott, Torkoal and Victini.
  • Overworld sprite fixes by @Liamjd14 (with help from @hedara90 to solve conflicts) in #5334
    • Palette Fixes: Shieldon.
    • Misc. Sprite Fixes Torkoal.
    • "Blinking pixels":
      • Ambipom, Armaldo, Crawdaunt, Crobat, Donphan, Flaaffy, Flygon, Grovyle, Hoppip, Igglybuff, Illumise, Jumpluff, Ledian, Ledyba, Mamoswine, Mantine, Marshtomp, Meganium, Mightyena, Miltank, Numel, Prinplup, Raikou, Roserade, Skarmory, Skiploom, Spinarak, Staraptor, Stunky, Torkoal, Wooper, Xatu, Yanma
  • Overworld Pokémon sprite changes by @Liamjd14 in #5336
    • Fixed "blinking pixels":
      * Alolan Graveler/Golem/Alolan/Ninetales
      * Dawn Wings Necrozma
      * Hisuian Growlithe/Arcanine
      * Winter Sawsbuck
    • Added missing Shiny Palettes
      • Calyrex Ice/Shadow Rider, Origin Dialga/Palkia, White-Striped Basculin, Therian Enamorus and Low-Key Toxtricity.
    • Removed Gigantamax Low-Key Toxtricity using base Low-Key follower sprites.
    • Fixed Shiny palettes
      • Alolan Marowak/Raichu, Eternal Flower Floette, Flabébé (All), Galarian Ponyta/Rapidash
      • Typhlosion-Hisui follower shiny stomach color wrong - done
    • Other sprite/palette fixes
      • Alolan Exeggutor/Marowak/Persian/Raichu/Sandshrew, Hisuian Sligoo/Goodra and Winter Sawsbuck.

⚔️ Battle General ⚔️

Changed

Fixed

  • Fixed Slateport Battle Tent/Battle Factory issues by @SarnPoke in #5281
    • Choosing the "SWAP" option no longer shows invalid Pokémon ("??????????").
    • Reloading after choosing "REST" no longer resets the player's challenge party to invalid Pokémon ("??????????").
  • Fixed Starting Status happening Wild Battles from a previous Trainer Battle by @PhallenTree in #5248
  • Fixed bugged behavior caused by Z-Moves and disobedience by @hedara90 in #5245
  • Fixed Entry Hazards targeting wrong side of the field if the opponent fainted by @PHalle...
Read more

Version 1.9.1

19 Aug 22:26
a11f03e
Compare
Choose a tag to compare
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.9.1`.

🌋 REFACTORS 🌋

  • Removed ENDTURN_RETALIATE in #5182
  • Removed ENDTURN_WEATHER_FORM and allowedToChangeFormInWeather in #5171

🧬 General 🧬

Added

Fixed

  • Fixes wrong padding field in SpeciesInfo struct by @AlexOn1ine in #5139
  • Fixed specific tiles changing to PC tiles when using Box Link/Debug PC option by @cawtds in #5141

🐉 Pokémon 🐉

Fixed

  • Fixed stray transparent pixels in Urshifu sprites by @hedara90 in #5071
  • Fixed bufferspeciesname not working for species IDs over 1023 by @SBird1337 in #5088
  • Fixed overworld Pokémon breaking for species IDs above 1535 by @hedara90, @mrgriffin and
    @SarnPoke in #5179
  • Fixed overworld palettes for multiple species by @hedara90 in #5107
    • Dialga Origin (Normal and Shiny)
    • Palkia Origin (Normal and Shiny)
    • Giratina Origin (shiny palette fixed by @hedara90 in #5108)
    • Xerneas Neutral/Active (Normal and Shiny)
    • Enamorus Incarnate/Therian (Normal and Shiny)
  • Fixed/added missing Pokémon sprites and palettes by @Cafeei in #5126
    • Overworld:
      • Shiny Sneasler, Morelul, Bounsweet, Bruxish, Guzzlord, Regieleki, Zacian, Zamazenta
      • Hisuian Zorua sprite
      • Shiny Summer Sawsbuck
      • Shiny Galarian Yamask, Darumaka, Zigzagoon, Zapdos, Ponyta, Rapidash, Slowpoke, Farfetch'd, Weezing, Mr. Mime, Articuno, Moltres, Slowking, Stunfisk, Darmanitan
      • Shiny Hisuian Sneasel, Qwilfish, Samurott,
    • Battle sprites:
      • Shiny Sneasler, Cursola, Pincurchin, Runerigus
      • Shiny Galarian Yamask, Darumaka
  • Fixed Unown Overworld follower sprites by Sarn by @hedara90 in #5146

⚔️ Battle General ⚔️

Changed

Fixed

  • Fixed speed ties by @mrgriffin in #4780
  • Fixed Defiant/Competitive not working after the battler enters the field with a Court Changed Sticky Web on its side of the field by @PhallenTree in #5093
  • Fixed trainerproc not properly parsing line markers, which caused erroring lines to be offset by @mrgriffin in #5122
  • Fixed initial Zigzagoon battle being able to use a Gimmick by @AlexOn1ine in #5129
  • Fixed incorrect rounding when maxHP is lower than 16 by @hedara90 in #5183
    • This caused these Pokémon to not be hurt by Sandstorm/Hail.
  • Fixes UB in Cmd_averagestats by @mrgriffin and @AlexOn1ine in #5191

🤹 Moves 🤹

Added

  • Added move animations for multiple moves by @TheTrueSadfish in #5159
    • Spin Out, Mortal Spin, Fillet Away, Flower Trick, Make It Rain, Shed Tail, Hyper Drill, Twin Beam, Comeuppance, Blood Moon, Fickle Beam, Thunder Clap, Hard Press, Dragon Cheer, Malignant Chain.
    • Purple chains by ogwon on Discord, beam by @TheTrueSadfish and livra on Discord.

Changed

  • Adjusted Raging Bull's animation to include Brick Break's wall break effect by @TheTrueSadfish in #5159

Fixed

  • Fixed non-grass Ivy Cudgel breaking battle UI by @hedara90 in #5117
  • Fixes Stomping Tantrum effect not doubling power in certain situations by @AlexOn1ine in #5140
  • Fixed Fickle Beam's description by @PhallenTree in #5093
  • Fixed Revelation Dance interactions with Z-Move, Roost and typeless mons by @PhallenTree in #5133
  • Fixes Poltergeist missing its accuracy check by @AlexOn1ine in #5168
  • Fixed Fickle Beam not showing its message by @TheTrueSadfish in #5159
  • Fixed Retaliate not working correctly if the party member fainted via passive damage during end of turn by @hedara90 in #5182
  • Fixed Flame Burst's passive damage being based off current HP rather than Max HP by @hedara90 in #5182
  • Fixed using Population Bomb with Loaded Dice printing garbage text by @kittenchilly in #5195

🎭 Abilities 🎭

Added

Fixed

  • Fixes Purifying Salt not halving damage for dynamic move types by @AlexOn1ine in #5145
  • Fixed Dancer-called moves not changing their type based on the new user by @PhallenTree in #5133
  • Fixed Ice Face not regenerating after switching in during Hail/Snow by @hedara90 in #5171
  • Fixed Wind Rider not activating when switched in while Tailwind is active on the user's side of the field activation and tests by @PhallenTree in #5207

🧶 Items 🧶

Added

Fixed

🤖 Battle AI 🤖

Changed

Fixed

  • Fix Switch AI Bug: AI never switching out when it could be OHKO'd by @Pawkkie in #5089
  • Adds missing AI checks for poltergeist by @AlexOn1ine in #5189

🧹 Other Cleanup 🧹

🧪 Test Runner 🧪

Added

Changed

Fixed

  • Fixed RandomUniformExcept not being exclusive on the higher boundary by @PhallenTree in #5170

📚 Documentation 📚

  • Added guide to running documentation website locally by @AsparagusEduardo in #5059
  • How to docs and fixes to be added to the mdbook documentation site by @anrichtait in #5070
  • Improved 1.8 ⇒ 1.9 non-Competitive syntax migration instructions by @mrgriffin in #5079

📦 Branch Synchronisation 📦

pret

  • 5th of August in #5098
    • Fixed bottom half o...
Read more

Version 1.9.0

02 Aug 00:10
a2685d0
Compare
Choose a tag to compare
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.9.0`.

🌋 REFACTORS 🌋

📜 = Has a migration script.

🧬 General 🧬

Added

  • Added migration script README by @Bassoonian in #4719

  • Customizable Frontier Pokémon sets by @ghoulslash in #4313

    • FacilityMon has been removed in favor of using regular TrainerMon.
    • Removed BATTLE_FRONTIER_ITEM_x item constants in favor of using regular ITEM_x constants.
    • New CreateFacilityMon to handle duplicated code.
      • Added FLAG_FRONTIER_MON_FACTORY that replaces Return for Frustration and sets frienship to 0. Used in the Battle Factory.
    • Converted data in src/data/battle_frontier/battle_frontier_mons.h and src/data/battle_frontier/battle_tent.h, for example:
      • .itemTableId = BATTLE_FRONTIER_ITEM_CHOICE_BAND, -> .heldItem = ITEM_CHOICE_BAND,
      • .evSpread = F_EV_SPREAD_SPEED | F_EV_SPREAD_ATTACK, -> .ev = TRAINER_PARTY_EVS(0, 252, 0, 252, 0, 0),
    • Migration script available in migration_scripts/egg_move_refactor.py by @AlexOn1ine in #5040
  • Added documentation to STATIC_ASSERTS used by the BoxPokemon after 1.8.0 by @pkmnsnfrn in #4294
  • Competitive-formatted parties by @mrgriffin in #3545

    • Can be disabled by setting COMPETITIVE_PARTY_SYNTAX to FALSE in include/config/general.h. If migrating from 1.8, remove the first and last lines from src/data/trainers.h (const struct Trainer gTrainers[] = { and }; respectively).
    • Introduces trainerproc, a tool which converts Competitive-formatted parties into Trainer Control-formatted parties.
    • If you made custom changes to the following files and want to use this new format, Do not accept the incoming changes for them. Instead, use the migration script present in migration_scripts/convert_parties.py:
      • src/data/trainers.h
      • src/data/trainer_parties.h
      • src/data/battle_partners.h
      • src/data/partner_parties.h
    • Before:
      static const struct TrainerMon sTestParty1[] =
      {
          {
              .species = SPECIES_WOBBUFFET,
              .ball = ITEM_MASTER_BALL,
              .ability = ABILITY_TELEPATHY,
              .friendship = 42,
              .gender = TRAINER_MON_FEMALE,
              .heldItem = ITEM_ASSAULT_VEST,
              .isShiny = TRUE,
              .iv = TRAINER_PARTY_IVS(25,26,27,28,29,30),
              .ev = TRAINER_PARTY_EVS(252, 0, 0, 252, 4, 0),
              .lvl = 67,
              .moves = {MOVE_AIR_SLASH, MOVE_BARRIER, MOVE_SOLAR_BEAM, MOVE_EXPLOSION},
              .nature = NATURE_HASTY,
              .nickname = COMPOUND_STRING("Bubbles")
          },
          {
              .species = SPECIES_WOBBUFFET,
              .ability = ABILITY_SHADOW_TAG,
              .lvl = 5,
          },
      };
      
      static const struct Trainer sTestTrainer1 =
      {
          .trainerName = _("Test1"),
          .party = TRAINER_PARTY(sTestParty1),
      };
      After:
      === 0 ===
      Name: Test1
      
      Bubbles (Wobbuffet) (F) @ Assault Vest
      Hasty Nature
      Level: 67
      Ability: Telepathy
      IVs: 25 HP / 26 Atk / 27 Def / 29 SpA / 30 SpD / 28 Spe
      EVs: 252 HP / 4 SpA / 252 Spe
      Happiness: 42
      Shiny: Yes
      Ball: Master Ball
      - Air Slash
      - Barrier
      - Solar Beam
      - Explosion
      
      Wobbuffet
      Level: 5
      Ability: Shadow Tag
      
    • You can add comments by using // or /* ... */, like in C.
    • You're allowed to write SPECIES_PIKACHU instead of Pikachu (etc etc) if you want.
    • In addition to the migration script described above, you can add the following to at the top of the src/data/trainers.party file to change how the tool interprets the file:
      • #pragma trainerproc ivs explicit — requires an IVs: line for every Pokémon instead of defaulting to 31s.
      • #pragma trainerproc ivs <IVs> — changes the default IVs.
      • #pragma trainerproc level explicit — requires a Level: line for every Pokémon instead of defaulting to 100.
      • #pragma trainerproc level <level> — changes the default level.
      • During the merge you could choose to keep your original src/data/trainers.h and src/data/trainer_parties.h and then run the conversion script to update the src/data/trainers.party, make, then check in all three files. Alternatively don't run the conversion script and turn off COMPETITIVE_PARTY_SYNTAX in include/config.h.
    • Added synonyms for competitive/CFRU species defines, eg:
      • SPECIES_PONYTA_GALAR for SPECIES_PONYTA_GALARIAN
      • SPECIES_MAUSHOLD_FOUR for SPECIES_MAUSHOLD_FAMILY_OF_FOUR
      • SPECIES_CHARIZARD_GMAX for SPECIES_CHARIZARD_GIGANTAMAX
      • And so.
    • TODO:
      • Support Hidden Power: to set IVs appropriate for a particular Hidden Power type.
      • Consider case-insensitivity in the parser.
    • Cleanup and bugfixes:
  • Added OW_PC_MOVE_ORDER config to use future generation's menu order for th...
Read more

Version 1.8.6

01 Aug 23:55
483121d
Compare
Choose a tag to compare
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.8.6`.

🌋 REFACTORS 🌋

🧬 General 🧬

Fixed

  • Fixed Battle Frontier ineligibility blocking the entire party if it encountered a disabled species by @Bassoonian in #4997
  • Fixed random IVs given when using givemon only giving values from 1-31 by @cawtds in #5021
  • Fixed givemon not giving Cherish Ball by @Sneed69 in #5022

🐉 Pokémon 🐉

Added

Changed

Fixed

⚔️ Battle General ⚔️

Fixed

  • Fixed Debug Menu not properly updating the corresponding flags + general cleanup by @kittenchilly in #4643
  • Fixed spread damage in double battles by @AlexOn1ine in #5064
    • In double battles when B_POSITION_OPPONENT_LEFT fainted from the first hit of a spread move, the second hit dealt 100% of damage to B_POSITION_OPPONENT_RIGHT.
  • Removed unused Battle Script labels by @Bassoonian in #4839

    • data/battle_scripts_1.s
      • BattleScript_OctolockTryLowerDef
      • BattleScript_OctolockTurnDmgPrintMsg
      • BattleScript_StuffCheeksEatBerry
      • BattleScript_StrengthSapTryHp and its contents.
      • BattleScript_PartingShotEnd and its contents.
      • BattleScript_RototillerAffected
      • BattleScript_AutotomizeDoAnim
      • BattleScript_TryTailwindAbilitiesLoop_Ret
      • BattleScript_HitFromAtkCanceler
      • BattleScript_EffectMultiHit
      • BattleScript_BattleScript_EffectParalyzeNoTypeCalc
      • BattleScript_EffectTeleportTryToRunAway
      • BattleScript_WindPowerActivates_Ret
      • BattleScript_CottonDownReturn
      • BattleScript_ActivateWeatherAbilities_Increment
      • BattleScript_IntimidateEnd
      • BattleScript_SupersweetSyrupEnd
      • BattleScript_ActivateTerrainEffects_Increment
      • BattleScript_GrassyTerrainHpChange
      • BattleScript_GrassyTerrainLoopEnd
      • BattleScript_AbilityNoSpecificStatLossPrint
      • BattleScript_ArenaNothingDecided
      • BattleScript_ExtremeEvoboostAtk
      • BattleScript_BerserkGeneRet_Anim
    • data/battle_scripts_2.s
      • BattleScript_PrintCaughtMonInfo
  • Opportunist/Mirror Herb Refactor by @AlexOn1ine in #4928

    • Multiple fixes:
      • Opportunist stacking multiple boosts in one turn from opposing mons.
      • Increasing the stat by the wrong amount when copying opposing boost (eg. +6 boosts).
      • Opportunist no longer has a message.
      • Opportunist only play animations once for every stat boost.
    • Changes:
      • switchInBattlerCounter replaces both switchInAbilitiesCounter and switchInItemsCounter.
      • Removed STRINGID_OPPORTUNISTCOPIED and sText_OpportunistCopied.
      • Altered TryDoEventsBeforeFirstTurn to use a state switch (gBattleStruct->eventsBeforeFirstTurnState)
        • FIRST_TURN_EVENTS_START.
        • FIRST_TURN_EVENTS_OVERWORLD_WEATHER.
        • FIRST_TURN_EVENTS_TERRAIN.
        • FIRST_TURN_EVENTS_STARTING_STATUS.
        • FIRST_TURN_EVENTS_TOTEM_BOOST.
        • FIRST_TURN_EVENTS_NEUTRALIZING_GAS.
        • FIRST_TURN_EVENTS_SWITCH_IN_ABILITIES.
        • FIRST_TURN_EVENTS_OPPORTUNIST_1.
        • FIRST_TURN_EVENTS_ITEM_EFFECTS.
        • FIRST_TURN_EVENTS_OPPORTUNIST_2.
        • FIRST_TURN_EVENTS_END.

🤹 Moves 🤹

Added

Fixed

  • Fixed Diamond Storm's Defense increase applying to the target instead of the user by @Bassoonian in #4947
  • Fixed Psycho Shift check for Frostbite using CanBeFrozen instead of CanGetFrostbite by @Bassoonian in #4995
  • Fixed Sleep Talk failing on repeated attempts by @PhallenTree in #5009
  • Fixed Fury Cutter considering Parental Bond's second hit for its damage multiplier by @PhallenTree in #5030
  • Fixed Hidden Power damage category when B_PHYSICAL_SPECIAL_SPLIT < GEN_4 by @hedara90 in #5053
  • Fixed MoveEffectRemoveStatus (Sparkling Aria, Wake-Up Slap, ...) that cure Freeze/Frostbite using the other status' battlescript. by @PhallenTree in #5061

🎭 Abilities 🎭

Fixed

  • Fixed Toxic Debris incorrect side check by @PhallenTree in #5009
  • Fixed Snow Warning's description not being updated based on B_SNOW_WARNING by @kittenchilly in #5018
  • Fixed Mold Breaker abilities not properly checking battler actions in double battles causing them to not work by @PhallenTree in #5030
  • Fixed cantBeSurpressed ability check for breakable abilities by @AlexOn1ine in #5043
  • Fixed Stalwart and Propeller Tail not ignoring redirection from Storm Drain/Lightning Rod + tests by @PhallenTree in #5061
  • Fixed Trace not respecting the speed order like other switch-in abilities by @AlexOn1ine in #4941

    • Changes:
      • Removed: ABILITYEFFECT_TRACE1, ABILITYEFFECT_TRACE2 and moved their handling to ABILITYEFFECT_ON_SWITCHIN.
      • Removed gSpecialStatuses's traced field.

🧶 Items 🧶

Fixed

  • Jaboca/Rowap Berry recording the wrong item effects by @PhallenTree in #5009
  • Fixed Life Orb damaging its holder if it hits itself in confusion. by @PhallenTree in #5061

🤖 Battle AI 🤖

Documentation

  • Added AI Flags documentation to directory for new documentation site by @anrichtait in #5057

Fixed

  • Fixed typo that caused AI to use Upper Hand when it shouldn't by @Pawkkie in #4973
  • Fixed AI using U-Turn when only the Ace Pokémon is left in the party (#4748) by @Pawkkie in #4972
  • Fixed AI not being aware during calculations by @AlexOn1ine in #4992
  • Fixed AI_SetMoveAccuracy getting the wrong battler's ability by @PhallenTree in #5030

🧹 Other Cleanup 🧹

Fixed

🧪 Test Runner 🧪

Added

Changed

  • Improved Test Runner Summary by @AsparagusEduardo in #4641
    • Totals are now separated from the erroring test list.
    • Assumption Fails and Passing KNOWN_FAILINGs now have their own lists.

Fixed

  • Fixed te...
Read more

Version 1.8.5

10 Jul 13:45
c0eb9af
Compare
Choose a tag to compare
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.8.5`.

🌋 IMPORTANT CHANGES AND REFACTORS 🌋

  • Small ABILITYEFFECT_MOVES_BLOCK refactor for readability by @AlexOn1ine in #4635
  • Removed redundant partnerPicId arguments in macros by @Bassoonian in #4736
  • Renamed some labels from "critical hit chance" to "critical hit odds" by @Sneed69 in #4751
    • sCriticalHitChance => sCriticalHitOdds.
    • GetCritHitChance => GetCritHitOdds.
  • Renamed BS_FAINTED_LINK_MULTIPLE_1/2 to BS_FAINTED_MULTIPLE_1/2 by @DizzyEggg in #4851
  • Remove Duplicate ai code from battle_ai_util.c by @AlexOn1ine in #4883
    • AI_CanBeBurned is now handled by CanBeBurned.
    • CanSleep renamed to CanBeSlept.
      • AI_CanSleep is now handled by CanBeSlept and added defAbility argument.
    • Added defAbility argument for CanBePoisoned.
    • Added defAbility argument for CanBeBurned.
    • Added defAbility argument for CanBeParalyzed.
  • Got rid of hardcoded stat raise anim values by @DizzyEggg in #4825
  • Added parentheses to SPECIES_EGG macro to avoid issues by @DizzyEggg in #4899
  • IsFinalStrikeEffect uses effect instead of move by @Sneed69 in #4917

💥 Softlock/Crash fixes 💥

  • Fixed Baton Pass hardlocking on Memento by @DizzyEggg in #4773
  • Fixed Revive in Double Battles causing a softlock by @DizzyEggg in #4784
  • Fixed Tectonic Rage causing a freeze after leveling up by @DizzyEggg in #4787
  • Fixed Smack Down's animation softlocking the game after around 13 uses by @DizzyEggg in #4774
  • Fixed softlock caused by using Covet/Thief on a Pokémon with Sticky Hold by @Sneed69 in #4885

🧬 General 🧬

Added

Fixed

  • Fixed Poké Ball inheritance into actually working by @cawtds in #4695
  • Daycare fixes by @Sneed69 in #4479
    • Fixed Evolved mons not copying moves as they do not have their own egg move table.
    • Fixed forms of the same species not copying egg moves from each other.
  • Fixed Roamer Frostbite status not carrying over between battles by @Sneed69 in #4822
  • Fixed Partners getting the wrong nature defined by @AlexOn1ine in #4926
  • Fixed Shop menu lists not properly displaying 6-digit item prices by @DizzyEggg in #4929

🐉 Pokémon 🐉

Changed

  • PokeCommunity sprites batch (May) by @kittenchilly in #4714
    • Pawmi (Front by KingOfThe-X-Roads, back by Vent, QC by leParagon)
    • Pawmo (By vent, qc by leParagon)
    • Okidogi (Front by KingOfThe-X-Roads + by leParagon, back by Lykeron + QC by Alexandrev2. 0)
    • Backported @hedara90's Terapagos from #4691
  • Updated wild held items to Gen 9 by @kittenchilly in #4769
    • Teddiursa (Common: None_> Honey)
    • Bisharp (Rare: None -> Leader's Crest)
    • All Oricorio: (Rare: Honey -> Corresponding Nectar)
    • Toedscool, Toedscruel: (Common: Tiny Mushroom, Rare: Big Mushroom)
    • All Paradox Mon: (Rare: Booster Energy)

Fixed

  • Fixed Tandemaus being able to evolve via Rare and Exp. Candies by @Bassoonian in #4759
  • Fixed Poltchageist not always producing Counterfeit form offspring by @kittenchilly in #4812
  • Fixed missing Minior Pokédex Entry by @cawtds in #4858
  • Multiple Pokemon sprite fixes by @cafei-uh in #4887
    • Fixed Charjabug shiny + cleaned up its front sprite
    • Changed Lurantis back sprite to better match its ingame model
    • Fixed Bounsweet shiny not changing the color of its lower body
    • Brightened the white color of Bruxish shiny + tweaked its sprites to accommodate the change
  • Fixed P_UPDATED_ABILITIES not reverting newly gained abilities in Gens 4/6/7 by @AsparagusEduardo in #4922

⚔️ Battle General ⚔️

Fixed

  • Fixed Dynamax HP not reverting upon fainting by @WillKolada in #4681
  • Fixed the partner's palette from shifting when throwing a Poké Ball by @Bassoonian in #4736
  • Fixed shiny value not being updated in battle, causing the palette to reset when reloading the sprites by @DizzyEggg in #4788
  • Fixed B_VAR_STARTING_STATUS every following terrains infinite by @DizzyEggg in #4795
  • Fixed Gen 7+ confusion self hurt chance from 1 in 3 to 33% by @Sneed69 in #4831
  • Fixed caught wild pokemon not restoring their used held item by @kittenchilly in #4803
  • Fixed AI's right slot switching-in too early by @DizzyEggg in #4851
  • Ported post-KO test improvements from closed PR by @AlexOn1ine in #4859
  • Fixed how switch-in effects are played out after multiple faints in the same turn by @DizzyEggg in #4864
  • Fixed Megas gaining abilities after fainting by @DizzyEggg in #4873

🤹 Moves 🤹

Fixed

  • Added missing ignoreSubstitute flags for Defog (only in Gen 4), Torment and Powder by @AlexOn1ine in #4623
  • Fixed Grassy Glide granting priority if it's converted to Max Move by @PhallenTree in #4659
  • Fixed Rampage moves not confusing the user if it's canceled by Protect and Type immunity by @Sneed69 in #4722
  • Fixed Tar shot the target always be to Fire regardless of existing types by @Sneed69 in #4756
  • Fixed Shell Side Arm by @AlexOn1ine in #4753
  • Fixed Body press using physical Defense stat changes instead of Sp. Defense stat stages in Wonder Room (still uses physical defense stat) by @DizzyEggg in #4792
  • Fixed Relic Song playing the transforming animation for species other than Meloetta by @DizzyEggg in #4799
  • Fixed Pursuit not being locked by Choice Items when used on an opponent switching out by @DizzyEggg in #4801
  • Fixed Encore's effect lasting only 2 turns if it was used after the opponent uses the move in the same turn by @DizzyEggg in #4802
  • Fixed Spectral Thief playing stat raise animation when the user has Contrary by @DizzyEggg in #4824
  • Fixed Fury Cutter scaling up to 640 power by @Sneed69 in #4846
  • Fixed moves with the ignoresTargetAbility flag ignoring the attacker's own ability by @Sneed69 in #4855
  • Fixed incorrect move names by @AlexOn1ine in #4854
    • Floral Healing
    • Jungle Healing
    • Oceanic Operetta
  • Fixed Grassy Terrain not healing on the final turn of its duratio...
Read more

Version 1.8.4

27 May 13:15
Compare
Choose a tag to compare
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.8.4`.

🌋 IMPORTANT CHANGES 🌋

Reverted Guillotine feature branch by @AsparagusEduardo:

  • This was a runtime decapitalization branch introduced silently in version 1.8.0. We didn't properly announce as it was hastily merged and we were hoping that future versions of it would have fixed issues that we encountered after the merge. However, issues kept piling on and we felt the need to revert it as it was also silently breaking other features as well.
  • We will work on an alternate decapitalization option in the future.

💥 Softlock/Crash fixes 💥

  • Fixed softlock caused by Destiny Bond triggering after Explosion by @AlexOn1ine in #4516
  • Fixed softlock caused by Future Sight trying to hit a fainted target by @AlexOn1ine in #4543
  • Fixed softlock caused by Galvanized Explosion being absorbed by Volt Absorb by @AlexOn1ine in #4601
  • Fixed softlock caused by Flinging a Razor Fang when the target had already moved by @hedara90 in #4625

🧬 General 🧬

Fixed

  • Fixed instances of Level Caps causing absurd amounts of Exp. by @Nopinou in #4505
  • Fixed GetBoxMonData evolution tracker reading garbage data if compiled with agbcc by @cawtds in #4510
  • Fixed potential Berry Tree mutation corruptions when compiling with agbcc by @Bassoonian in #4535
  • Added missing EOF newlines to species_info files by @Bassoonian in #4584
  • Fixed EVO_MODE_BATTLE_SPECIAL evolutions (only Sirfetch'd currently) triggering twice under certain situations by @cawtds in #4553
    • As a side effect, these evolutions no longer happen before other ones, instead being triggered in party order alongside EVO_MODE_NORMAL.

✨ Feature Branches ✨

TheXaman's Debug Menu:

Fixed

  • Fixed abilities past ID 255 not being properly being given to Pokémon using the debug menu's Give Pokémon option by @Bassoonian in #4576

SBird/Karathan's Dynamic Multichoices:

Changed

  • Dynamic Multichoice no longer plays sound on init by @Sneed69 in #4480

TheXaman's HGSS Pokédex Plus:

Fixed

  • Multiple evolution page fixes by @Sneed69 in #4514
    • Fixed duplicate icons when 2 or more evolution methods share the same target species (eg. Magnezone evolution via Thunder Stone or Electromagnetic field).
    • Fixed arrow not loading when there are multiple evolution methods to the same target species that hadn't been caught.
    • Fixed wonky D-Pad inconsistency when scrolling down.
    • Fixed regression from #3562 (1.7.0) that caused non-evolving Pokémon to not show their "X has no evolution" text.
      • Change from the original branch: The message no longer shows for Pokémon that are part of an evolutionary family, even if they don't evolve themselves (eg. Venusaur).
  • Added failsafe for Egg Groups without text defined by @AsparagusEduardo in #4628

ghoulslash's Saveblock Cleansing:

Changed

  • Adjusted description of FREE_MATCH_CALL config to clarify that the VS Seeker also utilizes that data by @Pawkkie in #4590

🐉 Pokémon 🐉

Added

Changed

  • Update various sprites to ones from PokeCommunity by @kittenchilly in #4554
  • Updated footprints to Gen 4/5 designs, being more accurate to their designs @kittenchilly in #4621
    • Golem, Ludicolo, Shroomish and Mawile.
    • Also updated Origin Giratina to have an empty footprint.
  • Explicitly define Gengar's 3rd ability slot (Hidden Ability) by @lhearachel in #4633

Fixed

  • Fixed animation errors by adding missing 2nd frames:
    • Keldeo Resolute and Meloetta Pirouette by @TheJamesLJ in #4541
    • White-Striped Basculin and Neutral Xerneas @cafei-uh in #4552
    • Summer, Autumn and Winter Sawsbuck by @cafei-uh in #4592
  • Fixed Unown B-Z and Punctuation Marks entry animations by @cafei-uh in #4546
  • Fixed Iron Hands and Iron Bundle incorrect backsprite palettes @cafei-uh in #4552
  • Fixed transparent pixel in Mega Mewtwo Y's backsprite eye by @TheJamesLJ in #4541
  • Fixed floating Munkidori backsprite @cafei-uh in #4552
  • Fixed Salandit's sprite and palettes by @BlueAnthem37510 in #4614
  • Fixed regression from #4230 (1.8.0) that caused Mr. Mime's typing to ignore P_UPDATED_TYPES by @PhallenTree in #4547
  • Fixed silent Oricorio Pom-Pom cry by @cafei-uh in #4551
  • Fixed regression from #4360 (1.8.2) that caused Shaymin to changing form with the incorrect status + receiving damage upon form change by @TheJamesLJ in #4559

⚔️ Battle General ⚔️

Fixed

  • Fixed Imposter and Transform causing the user to look shiny until screen is refreshed if they're not in the first party slot by @Sneed69 in #4486
  • Fixed regression in #4307 (1.8.2) that caused special battle types to not finish correctly by @ghoulslash in #4536
  • Fixed multiple Speed ignoring effects by @Sneed69 in #4613
    • Fixed Quick Draw always outspeeding Quick Claw and Custap Berry.
    • Fixed Myceleum Might always outspeeding Stall.

🤹 Moves 🤹

Changed

  • Ported Explosion/Mind Blown/Steel Beam implementation from CFRU (with tweaks) by @AlexOn1ine in #4516

Fixed

  • Fixes Thief and Covet used by an opponent not stealing items by @PhallenTree in #4506
  • Fixed Substitute, Fillet Away, Shed Tail and Belly Drum missing their HITMARKER_PASSIVE_DAMAGE, which weretriggering effects where they shouldn't by @hedara90 in #4533
  • Fixed Copycat issues by @PhallenTree in #4549
    • Copycat can no longer call Z-Moves.
    • 2-turn moves no longer play their animation twice when called by Copycat.
  • Fixed Substitute issues by @hedara90 in #4558
    • The following secondary effects no longer occur if the target is behind a Substitute.
      • Knock Off
      • Salt Cure
      • Smack Down/Thousand Arrows
      • Wake-Up Slap/Smelling Salts, including doubling in damage, unless they have the ignoresSubstitute like Sparkling Aria.
  • Fixed move animations by @Sneed69 in #4560
    • Animations using AnimTask_ShakeMonInPlace: Last Resort,, Aqua Tail, Earth Power, Giga Impact, Zen Headbutt, Rock Climb, Stone Edge and Attack Order
    • Animations using AnimTask_HorizontalShake: Sunsteel Strike and Chloroblast
  • Fixed Future Sight/Doom Desire triggering Focus Sash but not consuming the item moves by @hedara90 in #4625

🎭 Abilities 🎭

Fixed

  • Fixed Gulp Missile not triggering before fainting by @BlueAnthem37510 in #4502
  • Fixed Parental Bond converting Multi-Hit moves into in two-hit moves by @iriv24 in #4570
  • Fixed Magic Guard not preventing recoil damage by @iriv24 in #4578
  • Fixed Inner Focus, Scrappy, Oblivious and Own Temp granting immunity to all stat drops if the attacker has Intimidate by @kittenchilly in #4606
  • Fixed Moxie-like abilities not triggering when fainting the target with G-Max/Max Moves by @hedara90 in #4625

🧶 Items 🧶

Added

Read more

Version 1.8.3

06 May 18:48
7e43916
Compare
Choose a tag to compare
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.8.3`.

💥 Softlock/Crash fixes 💥

  • Fixed AI bug that caused an infinite loop when player mon has only status moves by @Pawkkie and @AlexOn1ine in #4403
  • Temporarely disabled AI_FLAG_SMART_MON_CHOICES flag in double battles to prevent a softlock by @Sneed69 in #4405
  • Fixed debug option "Fill PC Boxes Fast" softlocking the game by @mrgriffin in #4428
  • Fixed infinite loop caused by Leftovers with AI_FLAG_SMART_MON_CHOICES by @Pokabbie and @AlexOn1ine in #4453

🧬 General 🧬

Changed

Fixed

  • Fixed abilities not being properly inherited via breeding for species/abilities with IDs over 255 by @AsparagusEduardo in #4411
  • Fixed Hard Level Caps issues by @AlexOn1ine in #4420
    • Fixed Pokémon being able to surpass cap if they gained enough experience at once.
    • Fixed Exp. Candies ignoring hard caps.
    • Fixed Pokémon gaining 1 experience if they are at the level cap.
  • Fixed evolution tracker issues by @cawtds in #4503
    • EVO_LEVEL_MOVE_TWENTY_TIMES no longer increases with every move.
    • EVO_LEVEL_RECOIL_DAMAGE_MALE/FEMALE is no longer updated twice than intended.

✨ Feature Branches ✨

TheXaman's HGSS Pokédex Plus:

Fixed

🐉 Pokémon 🐉

Changed

  • Further Gen 9 Pokémon icon improvements by @kittenchilly in #4413
    • Original sprites by ezerart on DeviantArt. Palette assignments and 2nd frames by kittenchilly.
    • Cyclizar, Dipplin, Farigiraf, Glimmet, Glimmora, Greavard, Iron Moth, Revavroom, Tadbulb, Paldean Tauros (all three of them), Tinkaton and Paldean Wooper.
  • Further Gen 9 Pokémon front/back sprite improvements by @AlexOn1ine in #4414
    • Source: PokéCommunity
    • Dolliv, Arboliva, Charcadet, Mabosstiff, Tinkatink, Tinkatuff, Tinkaton and Chien-Pao.

Fixed

  • Fixed Lycanroc Dusk and Midnight forms using Midday's backsprite by @Eemeliri in #4430
  • Fixed Tatsugiri Droopy back sprite palette by @cafei-uh in #4455

⚔️ Battle General ⚔️

Changed

  • Turned B_RESTORE_HELD_BATTLE_ITEMS into a generational config by @LOuroboros in #4402

Fixed

  • Fixed battle Partner trainer class and potential OOB-related issues by @Bassoonian in #4422

🤹 Moves 🤹

Fixed

🎭 Abilities 🎭

Changed

  • Changed the Embody Aspect defines to use the full form name, to be in line with the species define by @kittenchilly in #4439
    • Eg. ABILITY_EMBODY_ASPECT_TEAL -> ABILITY_EMBODY_ASPECT_TEAL_MASK.

Fixed

  • Fixed Intimidate/Supersweet Syrup playing their animation and not printing the right message for battlers at -6 stage Attack/Evasion by @Sneed69 in #4406
  • Fixed ability pop ups not respecting abilityPopupOverwrite in tests by @kittenchilly in #4423
  • Fixed Dancer copying multi-target moves by @AlexOn1ine in #4437
  • Fixed Hospitality triggering on a fainted mon by @AlexOn1ine in #4450
  • Fixed Embody Aspect (Teal Mask) boosting Sp. Attack instead of Speed by @kittenchilly in #4439
  • Fixed lingering long ability popup names by @Sneed69 in #4456
  • Fixed Fur Coat not being skipped by Mold Breaker abilities by @Bassoonian in #4459
  • Fixed Color change not being triggered by Future Sight or Doom Desire by @AlexOn1ine and @hedara90 in #4472
  • Fixes Magic Bounce only working for battlers in certain positions by @AlexOn1ine in #4464
  • Fixed Costar, Zero to Hero, Supreme Overlord and Ruin abilities' switch-in battle messages showing sometimes incorrectly by @PhallenTree in #4500

🧶 Items 🧶

Fixed

  • Fixed typo in Rotom Catalogue description by @mrgriffin in #4433
  • Eject item fixes (Eject Button/Pack):
  • Fixed Flute Items being consumed in battle by @AsparagusEduardo in #4496
  • Fixed Red Card activating if the holder was switched in in the same turn (eg. via Endure) by @AlexOn1ine in #4482

🤖 Battle AI 🤖

Changed

🧪 Test Runner 🧪

Added

Changed

Fixed

  • Fixed AI test error messages by @mrgriffin in #4404
    • The error messages for EXPECT_MOVE and EXPECT_SWITCH were backwards, saying, e.g. Expected MOVE, got SWITCH when it should say Expected SWITCH, got MOVE.
  • Fixed typos in Embody Aspect tests by @kittenchilly in #4439
  • Fixed Battle Test organization by @AsparagusEduardo in #4504
    • Fixed Cud Chew's file being in the move effect folder.
    • Fixed Cud Chew's file name and test names (Cud Chuw).
    • Fixed Gastro Acid and Role Play's files being in the ability folder.
    • Moved Recoil file to move flags folder.
    • Renamed White Herb's file to restore_stats.c.
    • Renamed Techno Blast's file to change_type_on_item.c.
    • semi_invulnerable_moves.c to semi_invulnerable.c.
    • two_turn_moves.c to two_turns_attack.c.
    • Combined Burn Up/Double Shock to a single file fail_if_not_arg_type.c
    • Added Spit Up/Swallow files that point Stockpile's file.
    • Moved secondary effect files to their own folder.
    • Combinations of secondary effects moved to their own folder
    • Split hit_set_entry_hazards.c to separate files for Spikes/Stealth Rock.
    • Grouped Hex/Venoshock to the same file double_power_on_arg_status.c

New Contributors

Read more