Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from main #56565

Merged
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jul 20, 2021

  1. Configuration menu
    Copy the full SHA
    bd35632 View commit details
    Browse the repository at this point in the history
  2. Cleanup iOS/Android samples to use xharness (dotnet#55926)

    Instead of manually calling adb or simctl.
    akoeplinger authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    0e5e88c View commit details
    Browse the repository at this point in the history
  3. Complete Http2Stream after sending Reset or EndOfStream to server (do…

    …tnet#55835)
    
    It changes the order of Complete and Send Reset/Send EndOfStream operations to prevent creation of a new Http2Stream while the old one has not yet written the final frame to wire.
    
    Fixes dotnet#1586
    alnikola authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    ef2fe6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    89d0650 View commit details
    Browse the repository at this point in the history
  5. Fix % used in PerCoreLockedStacks (dotnet#55959)

    * Fix % used in PerCoreLockedStacks
    
    s_lockedStackCount will be a const in tier 1, and the JIT can optimize % by a const to something other than idiv.
    
    * Address PR feedback
    stephentoub authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    27e2c3f View commit details
    Browse the repository at this point in the history
  6. Replace a few unnecessary uses of Convert.ToString (dotnet#55831)

    * Replace a few unnecessary uses of Convert.ToString
    
    * Update src/libraries/System.Private.Xml/src/System/Xml/Schema/ContentValidator.cs
    
    Co-authored-by: Christopher Watford <83599748+watfordsuzy@users.noreply.github.com>
    
    Co-authored-by: Christopher Watford <83599748+watfordsuzy@users.noreply.github.com>
    stephentoub and watfordsuzy authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    6ca2a94 View commit details
    Browse the repository at this point in the history
  7. Fix x86 Linux build with clang < 10 (dotnet#55924)

    There is a bug in clang that was fixed in version 10 and that causes
    the build of the src/coreclr/vm/i386/jithelp.S to fail with
    'error: cannot use more than one symbol in memory operand'.
    The problem is that it doesn't support the `offset` keyword and
    it thinks it is just another symbol.
    
    The fix is to use att syntax for the offending instruction.
    janvorli authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    e063533 View commit details
    Browse the repository at this point in the history
  8. Disable QuicStreamTests_MsQuicProvider.ReadOutstanding_ReadAborted_Th…

    …rows (dotnet#55997)
    
    Disable test: System.Net.Quic.Tests.QuicStreamTests_MsQuicProvider.ReadOutstanding_ReadAborted_Throws
    
    Tracked by dotnet#55948
    karelz authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    85cf53d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6b09e32 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0a5e93b View commit details
    Browse the repository at this point in the history
  11. remove unnecessary call (dotnet#55795)

    * remove unnecessary call
    
    * fix typo
    wfurt authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    ef48adf View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f100379 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b29d06c View commit details
    Browse the repository at this point in the history
  14. Add profile-use-only mode for MultiCoreJit (dotnet#55005)

    * Add profile-use-only mode for MultiCoreJit
    
    - memory consumption is reduced if profile is not gathered
    - disk/flash life is increased if profile is not saved each time
    
    * Remove non-set m_fAppxMode
    gbalykov authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    cbfa7cf View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    775ecae View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e3cf002 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    b1af9bf View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5026c25 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b835c8c View commit details
    Browse the repository at this point in the history
  20. HTTP/3 & QUIC: fix abort read on dispose and cancellation (dotnet#55724)

    Fix abort on cancellation for HTTP/3 content stream, fix dispose when read was aborted by cancellation token.
    Fixes dotnet#48624
    CarnaViire authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    978b0db View commit details
    Browse the repository at this point in the history
  21. Fix tizen arm32 issue. (dotnet#55987)

    * Add asserts that we don't expect LONG copies on arm32.
    
    * Fix tizen.
    Sergey Andreenko authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    fc0f790 View commit details
    Browse the repository at this point in the history
  22. Revamp caching scheme in PoolingAsyncValueTaskMethodBuilder (dotnet#5…

    …5955)
    
    * Revamp caching scheme in PoolingAsyncValueTaskMethodBuilder
    
    The current scheme caches one instance per thread in a ThreadStatic, and then has a locked stack that all threads contend on; then to avoid blocking a thread while accessing the cache, locking is done with TryEnter rather than Enter, simply skipping the cache if there is any contention.  The locked stack is capped by default at ProcessorCount*4 objects.
    
    The new scheme is simpler: one instance per thread, one instance per core.  This ends up meaning fewer objects may be cached, but it also almost entirely eliminates contention between threads trying to rent/return objects.  As a result, under heavy load it can actually do a better job of using pooled objects as it doesn't bail on using the cache in the face of contention.  It also reduces concerns about larger machines being more negatively impacted by the caching.  Under lighter load, since we don't cache as many objects, it does mean we may end up allocating a bit more, but generally not much more (and the size of the object we do allocate is a reference-field smaller).
    
    * Address PR feedback
    stephentoub authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    776053f View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    3847790 View commit details
    Browse the repository at this point in the history
  24. Handle contained BITCAST for STORE_LCL_FLD (dotnet#55852)

    * Do not mark BITCAST as contained for STORE_LCL_FLD
    
    * Add unit test
    
    * Handle contained BITCAST in STORE_LCL_FLD
    
    * Return 100
    kunalspathak authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d38a539 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. [main] Update dependencies from mono/linker (dotnet#55813)

    * Update dependencies from https://github.com/mono/linker build 20210715.1
    
    Microsoft.NET.ILLink.Tasks
     From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21365.1
    
    * Update dependencies from https://github.com/mono/linker build 20210716.2
    
    Microsoft.NET.ILLink.Tasks
     From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21366.2
    
    * Suppress type hierarchy warnings
    
    Suppress type hierarchy warnings for
    DynamicallyAccessedMembers attribute on types that
    have members with RequiresUnreferencedCode (or derived
    types with such members).
    
    * Feedback
    
    Remove unnecessary local method
    
    * Fix typo
    
    * Update dependencies from https://github.com/mono/linker build 20210719.3
    
    Microsoft.NET.ILLink.Tasks
     From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21369.3
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    Co-authored-by: Sven Boemer <sbomer@gmail.com>
    3 people authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    aaba3c2 View commit details
    Browse the repository at this point in the history
  2. [wasm][debugger] Fix step behavior (dotnet#55915)

    * Creating test to close 49143.
    
    * Creating test to close dotnet#49141
    
    * Adding test for dotnet#49218.
    
    * Fix behavior of step to be the same of what we see when debugging using debugger-libs+mono or coreclr.
    Fix error message of evaluate calling methods.
    Adding test for dotnet#49142
    
    * Improving test to test what @radical asked.
    
    * Changing what was suggested by @radical.
    thaystg authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    f85f579 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9338fd8 View commit details
    Browse the repository at this point in the history
  4. Disable implicit namespace imports (dotnet#56046)

    * Disable implicit namespace imports
    safern authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b64df21 View commit details
    Browse the repository at this point in the history
  5. Disable test Connect_DualMode_MultiAddressFamilyConnect_RetrievedEndP…

    …oints_Success on Linux (dotnet#56002)
    
    * Disable test Connect_DualMode_MultiAddressFamilyConnect_RetrievedEndPoints_Success on Linux
    
    Disabled test tracked by dotnet#55053
    
    * Update Connect.cs
    karelz authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    5e17653 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9815e19 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5d4860a View commit details
    Browse the repository at this point in the history
  8. check handle before shutdown in quic connection Dispose (dotnet#56047)

    * check handle before shutdown in quic connection Dispose
    
    * add comment
    wfurt authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    577136c View commit details
    Browse the repository at this point in the history
  9. throw PNSE for unsupported SSL options in Quic. (dotnet#55877)

    * throw PNSP for unsupported SSL options
    
    * add missing resource file change
    
    * fix spacing
    wfurt authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b2107c5 View commit details
    Browse the repository at this point in the history
  10. [libraries][Android][iOSSimulator] Remove Active Issues from tests no…

    … longer failing due to properly set feature switches (dotnet#55974)
    mdh1418 authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    efbe6fd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7c72b72 View commit details
    Browse the repository at this point in the history
  12. [debugger] Export mono_debugger_agent_unhandled_exception to avoid us…

    …age of Debugger.Mono_UnhandledException (dotnet#55963)
    thaystg authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    3746672 View commit details
    Browse the repository at this point in the history
  13. Convert the last crossgen tests to use crossgen2 (dotnet#56061)

    - take advantage of the AlwaysUseCrossGen2 flag instead of manually updating all the crossgen commands
    - remove version bubbles test. We have much more complex testing for that scenario now
    - remove regular crossgen logic from the script generator
    davidwrighton authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    415356f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1a84b29 View commit details
    Browse the repository at this point in the history
  15. Disallow widening for explicit tailcalls (dotnet#55989)

    It is a runtime detail that the managed calling convention widens return
    values, so only allow this behavior for opportunistic tailcalls.
    
    Fix dotnet#55253
    jakobbotsch authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    94a8430 View commit details
    Browse the repository at this point in the history
  16. Fix outerloop System.Buffers tests after s_trimBuffers removal (dotne…

    …t#56068)
    
    We deleted this switch.  Turns out there were outerloop tests looking for it.
    stephentoub authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    2ad8c90 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    913facd View commit details
    Browse the repository at this point in the history
  18. [main] Update dependencies from 8 repositories (dotnet#55883)

    * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20210717.5
    
    optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
     From Version 1.0.0-prerelease.21365.5 -> To Version 1.0.0-prerelease.21367.5
    
    * Update dependencies from https://github.com/dotnet/runtime build 20210719.2
    
    Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , Microsoft.NET.Sdk.IL , System.Runtime.CompilerServices.Unsafe , System.Text.Json
     From Version 6.0.0-preview.7.21361.10 -> To Version 6.0.0-rc.1.21369.2
    
    * Update dependencies from https://github.com/dotnet/emsdk build 20210719.1
    
    Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
     From Version 6.0.0-rc.1.21365.1 -> To Version 6.0.0-rc.1.21369.1
    
    * Update dependencies from https://github.com/dotnet/arcade build 20210719.3
    
    Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
     From Version 6.0.0-beta.21366.1 -> To Version 6.0.0-beta.21369.3
    
    * Update dependencies from https://github.com/dotnet/icu build 20210719.1
    
    Microsoft.NETCore.Runtime.ICU.Transport
     From Version 6.0.0-rc.1.21366.2 -> To Version 6.0.0-rc.1.21369.1
    
    * Update dependencies from https://github.com/dotnet/llvm-project build 20210719.1
    
    runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
     From Version 11.1.0-alpha.1.21362.1 -> To Version 11.1.0-alpha.1.21369.1
    
    * Update dependencies from https://github.com/dotnet/runtime-assets build 20210719.1
    
    System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
     From Version 6.0.0-beta.21358.1 -> To Version 6.0.0-beta.21369.1
    
    * Update dependencies from https://github.com/dotnet/hotreload-utils build 20210719.1
    
    Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
     From Version 1.0.1-alpha.0.21364.1 -> To Version 1.0.1-alpha.0.21369.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b823f14 View commit details
    Browse the repository at this point in the history
  19. Resolve ILLink warnings in System.Linq.Expressions (Final) (dotnet#55856

    )
    
    * Resolve ILLink warnings in System.Linq.Expressions (Final)
    
    Suppress ILLink warnings for operator methods now that dotnet/linker#1821 is resolved.
    
    Add TrimmingTests for Linq.Expressions operators.
    
    Fix dotnet#45623
    eerhardt authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    a2f2a62 View commit details
    Browse the repository at this point in the history
  20. [wasm] Fix regression in compiling .bc -> .o files (dotnet#56063)

    * [wasm] Add back --emit-llvm that got removed mistakenly, in an earlier commit
    
    .. found thanks to Jerome Laban.
    
    * [wasm] Set EmccCompile's messages to MessageImportance.Low by default.
    
    .. and to MessageImportance.Normal if `$(EmccVerbose)==true`.
    
    * [wasm] Quote filenames passed to emcc compile command line
    
    * Add more blazorwasm tests - for debug/release, aot/relinking
    
    * Bump sdk for workload testing to 6.0.100-rc.1.21370.2
    
    * [wasm] Fix regression in compiling bitcode -> .o
    
    The `-emit-llvm` arg has been incorrectly added, and removed from the
    args used for compiling .bc->.o .
    
    This commit fixes it, and adds a crude test for it, so we don't regress
    again.
    
    * Fix build
    radical authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    1d8ad03 View commit details
    Browse the repository at this point in the history
  21. [Android][libraries] TimeZoneInfo Android imp (dotnet#54845)

    Fixes dotnet#41867
    
    Android has removed zone.tab, so TimeZoneInfo.Unix.cs will no longer work properly on Android as GetTimeZoneIds directly depends on the zone.tab file. The chain of dependency is as follows
     
    GetSystemTimeZones -> PopulateAllSystemTimeZones -> GetTimeZoneIds -> zone.tab
                    TZI.cs                                  TZI.Unix.cs                        TZI.Unix.cs         TZI.Unix.cs
     Where TZI is TimeZoneInfo
    
    zone.tab is a file that is found on the unix system under /usr/share/zoneinfo/
    GetTimeZoneIds reads zone.tab to obtain the TimeZoneId in that file
    PopulateAllSystemTimeZones caches all the TimeZone Ids in cachedData
    GetSystemTimeZones returns a ReadOnlyCollection containing all valid TimeZone’s from the local machine, and the entries are sorted by their DisplayName. It relies on cachedData._systemTimeZones being populated.
    
    The problem is that the time zone data for Android can be found in the file tzdata at the possible locations
    
    /apex/com.android.tzdata/etc/tz/tzdata
    /apex/com.android.runtime/etc/tz/tzdata
    /data/misc/zoneinfo/tzdata
    /system/usr/share/zoneinfo/tzdata
    
    The rest of unix the time zone data can be found in the file zone.tab at
    
     /usr/share/zoneinfo/zone.tab
    Android's TimeZoneInfo implementation should read time zone data from its locations instead of the general /usr/share/zoneinfo/zone.tab path. Moreover, tzdata contains all timezones byte data.
    
    This PR achieves the following:
    
    1. Splits TimeZoneInfo.Unix.cs into TimeZoneInfo.Unix.cs, TimeZoneInfo.Unix.NonAndroid.cs (non-Android), and 
        TimeZoneInfo.Unix.Android.cs (Android specific)
    2. Adds an interop to obtain the default time zone on Android based on persist.sys.timezone
    3. Implements GetLocalTimeZoneCore TryGetTimeZoneFromLocalMachineCore and GetTimeZoneIds for Android 
        based on mono/mono implementation 
        https://github.com/mono/mono/blob/main/mcs/class/corlib/System/TimeZoneInfo.Android.cs
    4. Adds new string resources to throw exceptions
    5. Refactors the mono/mono implementation of parsing tzdata
    
    Android tzdata files are found in the format of
    Header <Beginning of Entry Index> Entry Entry Entry ... Entry <Beginning of Data Index> <TZDATA>
    
    https://github.com/aosp-mirror/platform_bionic/blob/master/libc/tzcode/bionic.cpp
    
    The header (24 bytes) contains the following information
    signature - 12 bytes of the form "tzdata2012f\0" where 2012f is subject to change
    index offset - 4 bytes that denotes the offset at which the index of the tzdata file starts
    data offset - 4 bytes that denotes the offset at which the data of the tzdata file starts
    final offset - 4 bytes that used to denote the final offset, which we don't use but will note.
    
    Each Data Entry (52 bytes) can be used to generate a TimeZoneInfo and contain the following information
    id - 40 bytes that contain the id of the time zone data entry timezone<id>
    byte offset - 4 bytes that denote the offset from the data offset timezone<id> data can be found
    length - 4 bytes that denote the length of the data for timezone<id>
    unused - 4 bytes that used to be raw GMT offset, but now is always 0 since tzdata2014f (L).
    
    When GetLocalTimeZoneCore TryGetTimeZoneFromLocalMachineCore or GetTimeZoneIds are called, an android timezone data instance is instantiated and loaded by attempting to load a tzdata file that can be found at four locations mentioned earlier. The file is parsed by first loading the header which contains information about where the data index and data begin. The data index is then parsed to obtain the timezone and the corresponding bytes location in the file to fill the three arrays _ids _byteOffsets _lengths. These arrays are referenced to obtain the corresponding byte data for a timezone, and functions from TimeZoneInfo.Unix.cs are leveraged to create a TimeZoneInfo from there.
    mdh1418 authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    46d9b31 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    52262b8 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    37b3649 View commit details
    Browse the repository at this point in the history
  24. Update dependencies from https://github.com/mono/linker build 2021072…

    …0.1 (dotnet#56086)
    
    Microsoft.NET.ILLink.Tasks
     From Version 6.0.100-preview.6.21369.3 -> To Version 6.0.100-preview.6.21370.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    e6fc5d2 View commit details
    Browse the repository at this point in the history
  25. Disable [QUIC] WriteCanceled_NextWriteThrows on Mock (dotnet#56078)

    Disable [QUIC] WriteCanceled_NextWriteThrows on Mock
    
    Disabled test tracked by dotnet#55995
    karelz authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b4328ed View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    e8d536f View commit details
    Browse the repository at this point in the history
  27. Remove QuicStream.ShutdownWriteCompleted method (dotnet#55981)

    * remove QuicStream.ShutdownWriteCompleted API and associated implementation logic
    
    Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
    geoffkizer and Geoffrey Kizer authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    8ece868 View commit details
    Browse the repository at this point in the history
  28. Fix an issue where we are not injecting more HTTP2 connections when w…

    …e should (dotnet#56062)
    
    * fix an issue where we are not injecting more HTTP2 connections when we should
    
    Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    3 people authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    1fe60d3 View commit details
    Browse the repository at this point in the history
  29. reenable ConnectTimeout_PlaintextStreamFilterTimesOut_Throws test (do…

    …tnet#55982)
    
    * reenable ConnectTimeout_PlaintextStreamFilterTimesOut_Throws test
    
    Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
    geoffkizer and Geoffrey Kizer authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    016851a View commit details
    Browse the repository at this point in the history
  30. Make System.Drawing.Common throw on Unix unless a config switch is set (

    dotnet#55962)
    
    * Make System.Drawing.Common throw on Unix unless a config switch is set
    safern authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    2ccf787 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    3f82721 View commit details
    Browse the repository at this point in the history
  32. Lsra heuristic tuning experiment report (dotnet#56103)

    * lsra tuning experiments
    
    * remove the trailing space
    
    * Review comment
    kunalspathak authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b2264cb View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. proposed fix dotnet#33727 for illegal instruction in arm (dotnet#55502)

    * proposed fix dotnet#33727
    
    * fix for arm checked build error to crossgen the native System.Private.CoreLib.dll
    
    * fix for error:unannotated fall-through between switch labels
    
    * fix clang-format error
    
    * fix clang-format error
    
    * apply format.patch
    oldzhu authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    9391b4d View commit details
    Browse the repository at this point in the history
  2. Big-endian fixes: various problems in ilasm (dotnet#55349)

    * Byte-swap property and parameter default values of string type
    
    * Prepare custom attribute blobs in little-endian byte order
    
    * Fix byte order of ELEMENT_TYPE_TYPEDEF typespec blobs
    
    * Fix byte order of VTable blobs
    uweigand authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    cc7a8ef View commit details
    Browse the repository at this point in the history
  3. JIT: track memory loop dependence of trees during value numbering (do…

    …tnet#55936)
    
    Leverage value numbering's alias analysis to annotate trees with the loop
    memory dependence of the tree's value number.
    
    First, refactor the `mapStore` value number so that it also tracks the loop
    number where the store occurs. This is done via an extra non-value-num arg,
    so add appropriate bypasses to logic in the jit that expect to only find
    value number args. Also update the dumping to display the loop information.
    
    Next, during VN computation, record loop memory dependence from `mapStores`
    with the tree currently being value numbered, whenever a value number comes
    from a particular map. There may be multiple such recording events per tree,
    so add logic on the recording side to track the most constraining dependence.
    Note value numbering happens in execution order, so there is an unambiguous
    current tree being value numbered.
    
    This dependence info is tracked via a side map.
    
    Finally, during hoisting, for each potentially hoistable tree, consult the side
    map to recover the loop memory dependence of a tree, and if that dependence is
    at or within the loop that we're hoisting from, block the hoist.
    
    I've also absorbed the former class var (static field) hosting exclusion into
    this new logic. This gives us slightly more relaxed dependence in some cases.
    
    Resolves dotnet#54118.
    AndyAyersMS authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    1b4f786 View commit details
    Browse the repository at this point in the history
  4. Build VS installers for WebAssembly and Mobile workloads (dotnet#55769)

    In order to support generating installers, this change adds the mono.workloads subset and the associated yml.
    directhex authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    e60882e View commit details
    Browse the repository at this point in the history
  5. Consume PosixSignal in Hosting's ConsoleLifetime (dotnet#56057)

    * Add NetCoreAppCurrent target to Microsoft.Extensions.Hosting
    
    * Handle SIGTERM in Hosting and handle just like SIGINT (CTRL+C)
    
    Don't listen to ProcessExit on net6.0+ in Hosting anymore. This allows for Environment.Exit to not hang the app.
    Don't clobber ExitCode during ProcessExit now that SIGTERM is handled separately.
    
    For non-net6.0 targets, only wait for the shutdown timeout, so the process doesn't hang forever.
    
    Fix dotnet#55417
    Fix dotnet#44086
    Fix dotnet#50397
    Fix dotnet#42224
    Fix dotnet#35990
    
    * Remove _shutdownBlock on netcoreappcurrent, as this is no longer waited on
    * Change Console.CancelKeyPress to use PosixSignalRegistration SIGINT and SIGQUIT
    * Use a no-op lifetime on mobile platforms
    
    * Add docs for shutdown
    eerhardt authored Jul 22, 2021
    1 Configuration menu
    Copy the full SHA
    36f3f97 View commit details
    Browse the repository at this point in the history
  6. Remove disabled tests that depend on the verifier (dotnet#56118)

    The verifier is not supported in .NET Core.
    
    Fixes dotnet#5812
    BruceForstall authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    136be33 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d82faa5 View commit details
    Browse the repository at this point in the history
  8. Improve MetricEventSource error handling (dotnet#56083)

    Enabling multiple instances of a collection tool was causing
    both tools to lose their connections and it wasn't obvious from
    within the tool what had happened. I modified the behavior so
    that once a tool connects successfully it should never be
    disconnected and made a distinctive error event so that
    the additional tool instances can easily identify they are trying
    an unsupported operation.
    noahfalk authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    14d6532 View commit details
    Browse the repository at this point in the history
  9. Handle new DOTNET_ in complement to old COMPlus_ envvar prefix on Mon…

    …o. (dotnet#56098)
    
    dotnet#50507 added support for DOTNET_
    prefix for env variables previously using COMPlus_. That change was
    however not implemented on Mono, still using COMPlus for some EventPipe,
    DiagnosticServer env variables. This fix adds similar support on Mono,
    first looking for a DOTNET_ version of the environment variable and if
    not found, fallback to old COMPlus_ as fallback.
    
    Documentation for .net6 have been updated to use new names:
    https://docs.microsoft.com/en-us/dotnet/core/diagnostics/eventpipe#trace-using-environment-variables
    lateralusX authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    d38202e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    57fa2fc View commit details
    Browse the repository at this point in the history
  11. - Enable full float32 support (dotnet#56111)

    -- Add instructions for FP operations: abs[f]/ceil[f]/floor[f]/round[f]/sqrt[f]/trunc[f]
    -- Enable these instructions in mono_arch_emit_inst_for_method()
    -- Handle return of float32 results
    -- Correct rounding mode for OP_LCONV_TO_R_UN processing
    - Enable MONO_OPT_LINEAR optimizations
    -- Correct prolog processing of structure returned variable
    - Rework OP_LOCALLOC for cases where alloc size > 4k
    - Add OP_POPCNTxx support
    - Minor typo (missing tab)
    nealef authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    b937677 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    290430e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    bc7b910 View commit details
    Browse the repository at this point in the history
  14. [main] Update dependencies from dnceng/internal/dotnet-optimization d…

    …otnet/arcade dotnet/xharness dotnet/runtime-assets (dotnet#56088)
    
    [main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/arcade dotnet/xharness dotnet/runtime-assets
    
    
     - Fix package testing
    
     - Merge branch 'main' into darc-main-bdcf3772-495a-406e-a53b-da4d8acc1985
    dotnet-maestro[bot] authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    17ada00 View commit details
    Browse the repository at this point in the history
  15. Enable EHCONT for some DLLs and for PGO instrumentation (dotnet#55942)

    * Enable `EHCONT` for some DLLs and for PGO instrumentation
    
    - PGD files used for PGO optimziation need to be collected/produced against binaries with identical compiler features
    - Enabled `/guard:ehcont` as a compiler option but not as a linker option
    - Enabled `/guard:ehcont` and `/cetcompat` as a linker options for PGO instrumentation only for now
    - Once new profile data is published, another PR would follow to enable `/guard:ehcont` and `/cetcompat` as linker options
    
    * Fix build
    kouvel authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    f28702c View commit details
    Browse the repository at this point in the history
  16. [wasm] Fix invariant globalization test (dotnet#56121)

    The following commit changed the behavior to throw `CultureNotFoundException`
    when creating cultures in invariant mode.
    
    ```
    commit 04dac7b
    Author: Tarek Mahmoud Sayed <tarekms@microsoft.com>
    Date:   Thu Jul 1 11:55:05 2021 -0700
    
        Allow restricting cultures creation with any arbitrary names in Globalization Invariant Mode (dotnet#54247)
    ```
    
    This commit updates the corresponding test in `Wasm.Build.Tests` to
    handle that explicitly.
    
    Fixes dotnet#55838
    radical authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    6d15a02 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    0a4dde9 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    4bab779 View commit details
    Browse the repository at this point in the history
  19. Update System.Net.Security Telemetry tests (dotnet#55910)

    * Update System.Net.Security Telemetry tests
    
    * Always return Task from ProcessAuthenticationAsync
    
    * Name bool arguments
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    MihaZupan and stephentoub authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    12c4e4c View commit details
    Browse the repository at this point in the history
  20. Make polling use the symbolic link target's LastWriteTime (dotnet#55664)

    * Relax LinkTarget so it always returns null when steps on an error
    
    * Make polling use the symbolic link target's LastWriteTime
    
    * Fix for the case where the link can change its target
    
    * Add more test cases and exclude them from non-netcoreapp tfms
    
    * Fix project references in ref projects
    
    * Do not use UnsupportedOSPlatforms on test project in order to fix CI issue
    
    * Do not return link's LastWriteTime when target not exists
    
    * Address feedback on tests and improve them to cover more scenarios.
    
    * Make the project unsupported in browser.
    
    * Fix duplicate reference to PlatformAttributes with IncludePlatformAttributes=false
    
    * Disable default items for browser
    
    * Undo unrelated changes to Strings.resx
    
    * Replace Thread.Sleep with Task.Delay, add assertion messages to try to debug CI failures and increase delay between writes
    
    * Replace HasChanged for RegisterChangeCallback in tests
    
    * Add messages to asserts to attempt to debug CI issues
    
    * Add date format to assertion messages.
    
    * Increase delay between writes to one second since OSX doesn't report milliseconds
    jozkee authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    101e68a View commit details
    Browse the repository at this point in the history
  21. Improve Guid parsing performance for "D", "N", "B", and "P" (dotnet#5…

    …5792)
    
    * Improve Guid parsing for "D", "N", "B", and "P"
    
    * Update src/libraries/System.Private.CoreLib/src/System/Guid.cs
    stephentoub authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    676353c View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    541850a View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    1e41fd3 View commit details
    Browse the repository at this point in the history
  24. Fix EH issues with SPMI and crossgen2 (dotnet#56054)

    * Remove last vestiges of the PAL exception handling from the JIT-EE interfaces
    
    * Centralize the tweaks to allow finally behavior for crossgen2 exceptions in SPMI
    - Centralize the exception filter to capture data with completely common code
    - On unix, capture Crossgen2 triggered exceptions as exception code 1 (As was done for getCallInfo only before)
    - Use a bunch of templates to reduce the code bloat in SPMI
    
    With these changes catching exceptions should be more reliable. However, I was unable to reproduce the failure, so I need some jit team expertise to identify if these fixes are good.
    
    Fixes dotnet#49563
    davidwrighton authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    f96ca33 View commit details
    Browse the repository at this point in the history
  25. instrumentation changes (dotnet#55888)

    We've never had ETW events that had fields about time - we rely on the the timestamps of the ETW events themselves to calculate time. This checkin introduces some new events/event fields that will include time info instead of firing individual events that otherwise don't carry much info, ie, they'd just be there so we could use their timestamps, which would be a nuisance when we have many heaps.
    
    The rationale behind firing events with time already calculated is 
    
    1) it does reduce overhead since we don't fire as many events so we can fire these in fewer events for informational level
    2) firing individual vents and having the tools interpret them isn't very useful unlike events such as GCStart/GCEnd which can be correlated with other events (eg, you get GCStart, and then get a bunch of other events so you know those happened after a GC started) wheras things like very GC internal things don't have this property, ie, we are not gonna care that "these other events happened during a GC and specifically during the relocaton phase". 
    
    ---
    
    Added MarkWithType events for marking due to dependent handles, newly promoted due to dead finalizable objects and mark_steal. Perfview needs to be updated to work with this otherwise you can't see the GCStats view (I'm submitting a PR for that).
    
    Recorded time for marking roots (but sizedref is separate), short weak, ScanForFinalization, long weak, relocate, compact and sweep.
    
    Added a new version that includes the size of the object that triggered the event. This is for a request from dotnet#49424 (comment). 
    
    Provided a new rundown GCSettings event that has info on settings hard to get from traces. 
    
    Added a GCLOHCompact event which is fired for all heaps (heaps that didn't actually do LOH compact would have values of all 0s). I'm trying to add events that don't require a lot of correlation with other events to interpret. This is to help get an idea how long it takes to compact LOH and how reference rich it is.
    
    Added a verbose level GCFitBucketInfo event which helps us with FL fitting investigation. I'm firing this for 2 things in a gen1 GC:
    
    1) for plugs that allocated with allocate_in_condemned_generations the event will capture all of them with the same bucketing as we do for gen2 FL;
    
    2) for gen2 FL we look at the largest free items that take up 25% of the FL space, or if there are too many of them we stop after walking a certain number of free items as we have to limit the amount of time we are spending here. 
    
    ---
    
    Fixed issues -
    
    For BGC we were reporting the pinned object count the same as the last FGC..and that causes confusion so fixed that.
    
    Fixed dotnet#45375
    
    While fixing dotnet#45375, I noticed we have another bug related to alloc tick which is we are not firing the alloc tick events correctly for LOH and POH since the ETW alloc tracking didn't seperate them... fixed this too.
    
    Added the POH type for GCSegmentTypeMap which was missing in the manifest.
    
    ---
    
    Did some cleanup in eventtrace.h - we don't need the info that's not used which means we just ended up duplicating things like _GC_ROOT_KIND in more places than needed. 
    
    ---
    
    Note, I realize that I do have some inconsistency with the FEAETURE_EVENT_TRACE here, as in, some code should be under an #ifdef check but is not. I will look into a remedy for that with a separate PR.
    Maoni0 authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    921bca0 View commit details
    Browse the repository at this point in the history
  26. Remove diasymreader from source build (dotnet#56116)

    * Remove diasymreader from source build
    
    * Remove Diasymreader from crossgen2 package in source build scenarios
    davidwrighton authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    ece8fc0 View commit details
    Browse the repository at this point in the history
  27. Update SDK to 6.0 Preview 5 (dotnet#55283)

    * Update SDK to 6.0 Preview 5
    
    Part of dotnet#55281
    
    * Enable COM support to work around missing symbols in tests
    
    * Update eng/testing/linker/project.csproj.template
    
    * Disable the workload targets
    
    * Disable workloads for wasm builds
    
    For in-tree builds, and tests we don't want to use workloads from dotnet
    being used to build these.
    
    For the projects being built on the build machine, we can disable them
    via `Directory.Build.props`, and wasm's InTree/LocalBuild props. But for
    projects that get built on helix, eg. the runtime tests, we are setting
    the property values as environment variables.
    
    * Fix setting envvars for disabling workloads
    
    * Another attempt to fix wasm tests
    
    In preview5, the workload manifest overrides
    `$(UsingBrowserRuntimeWorkload)` setting, so pass it on the command
    line.
    
    ``xml
        <PropertyGroup Condition="'$(RuntimeIdentifier)' == 'browser-wasm'">
            <UsingBrowserRuntimeWorkload Condition="'$(RunAOTCompilation)' == 'true' or '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true'" >true</UsingBrowserRuntimeWorkload>
            <UsingBrowserRuntimeWorkload Condition="'$(UsingBrowserRuntimeWorkload)' == ''" >$(WasmNativeWorkload)</UsingBrowserRuntimeWorkload>
        </PropertyGroup>
    ```
    
    * Fix host tests after upgrade to P5
    
    In P5 we don't generate .runtimeconfig.dev.json anymore. Some tests started to fail because they relied on the .runtime.dev.json to include local nuget cache in the probing paths.
    
    I changed one of those tests to force-generate .runtimeconfig.dev.json as for the tested scenario it seems to make sense. For the other test I modified it to copy the necessary dependency into the right location instead.
    
    * Fix up reflection to private FileStatus field
    
    * Disable workload resolver for wasm.build.tests, EMSDK run
    
    * Disable workloads for wasm with MSBuildEnableWorkloadResolver=false everywhere
    
    * remove linker workaround
    
    * [wasm] Remove args unnecessary for disabling workloads
    
    * Pass MSBuildEnableWorkloadResolver property to individual trimming projects
    
    Co-authored-by: Juan Sebastian Hoyos Ayala <juhoyosa@microsoft.com>
    Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
    Co-authored-by: Larry Ewing <lewing@microsoft.com>
    Co-authored-by: Ankit Jain <radical@gmail.com>
    Co-authored-by: vitek-karas <vitek.karas@microsoft.com>
    Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
    8 people authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    159a01a View commit details
    Browse the repository at this point in the history
  28. [iOS/tvOS/MacCatalyst] Disable some of the library tests due to failu…

    …res (dotnet#56074)
    
    It's to clean up the respective CI staging lanes.
    
    The related issues:
    
    [iOS/tvOS/MacCatalyst] Test failures in System.Diagnostics.Tracing.Tests dotnet#56073
    
    [libraries][iOSSimulator] ImageTests.FromFile_NullFileName_ThrowsArgumentNullException fails  dotnet#56048
    
    JitInfoIsPopulated failed with after is not greater than before dotnet#55712
    
    [MacCatalyst] Test failures in System.Tests.OperatingSystemTests dotnet#56084
    
    [MacCatalyst] App crash in System.Text.Json.SourceGeneration.Tests dotnet#56085
    MaximLipnin authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    f5ed68b View commit details
    Browse the repository at this point in the history
  29. Translate SocketError.MessageSize to IPStatus.PacketTooBig in Ping.Se…

    …ndPing[Async] (dotnet#56092)
    
    * Translate SocketError.MessageSize to IPStatus.PacketTooBig in Ping.SendPing[Async]
    
    * Address feedback
    
    * Remove extra whitespace
    filipnavara authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    00b81b0 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    4d08b80 View commit details
    Browse the repository at this point in the history
  31. Fix DeserializeAsyncEnumerable streaming behavior (dotnet#56080)

    Fixes regression introduced by dotnet#51702: the ContinueDeserialize method will return 'null' on partial reads so no elements will be yielded by the enumerator until the entire stream has been consumed.
    
    This change reverts to the original implementation where the partially populated queue is being fetched from the ReadStack instead.
    eiriktsarpalis authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    0a3e317 View commit details
    Browse the repository at this point in the history
  32. Fix build break (dotnet#56179)

    Disable the warning until a proper fix can be made.
    
    See dotnet#56178
    eerhardt authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    77d23f0 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    c205295 View commit details
    Browse the repository at this point in the history
  34. Fix DAC issue with redefined standard new / delete operators (dotnet#…

    …55945)
    
    I have found that since .NET 6 preview 5, SOS on macOS arm64 crashes
    when running basic commands like clrstack due to the fact that
    its std::string allocations are done using standard new operator,
    but the freeing at some places is done using our overriden delete
    operator due to inlining of STL code.
    
    This change removes our redefinitions of those operators for DAC
    compilation, so this clash cannot happen.
    janvorli authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    a81fee2 View commit details
    Browse the repository at this point in the history
  35. JIT: work around issue with GDV and Bboxing (dotnet#56126)

    If a call is a GDV candidate and returns a struct via hidden buffer, and that
    return value is immediately boxed, the GDV expansion will produce IR in
    incorrect order, leading to bad codegen.
    
    This seems to be a rare enough sequence that disabling GDV is a reasonable
    workaround for now.
    
    Actually the box expansion is producing IR in the wrong order and GDV fails
    to fix the order (unlike inlining, which does fix the order).
    
    Longer term we should avoid producing out of order IR. But that seems a bit
    more complicated and may have other CQ impact.
    
    Added a test case.
    
    Closes dotnet#53549.
    AndyAyersMS authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    47e82c1 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    b92360a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Use checked math with CryptoStream buffer calculations

    In .NET Framework, .NET 5, and .NET Core the block scaling logic was used for
    `new byte[inputCount / inputBlockSize * outputBlockSize]` (or swap in/out).
    That expression throws an OverflowException when the computed size
    overflows.
    
    Earlier in .NET 6 we changed to use ArrayPool.Rent.  When ArrayPool.Rent gets a
    negative (overflowed) number it instead throws an ArgumentException.
    
    This change restores the OverflowException, so that we're not leaking an
    ArgumentException back to the caller.  (While the caller can control the
    behavior with the arguments they pass to CryptoStream.Read/Write, the
    description and paramName don't map in an obvious manner)
    
    Making the scenario work has virtue, but requires a larger test investment than
    we can make at this time.
    bartonjs authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    058a531 View commit details
    Browse the repository at this point in the history
  2. Call the jit shutdown logic on crossgen2 shutdown (dotnet#56187)

    - Allows the jit shutdown logic to execute reliably on both Windows and Unix
    davidwrighton authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    d20fdf1 View commit details
    Browse the repository at this point in the history
  3. Make Extensions.FileProviders supported in browser and only unsupport…

    … FSW usage (dotnet#56189)
    
    * Make Extensions.FileProviders supported in browser and only unsupport FSW usage
    
    * Disable CA1416 only for TryEnableFileSystemWatcher
    jozkee authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    aa0cf93 View commit details
    Browse the repository at this point in the history
  4. Disable JIT xarch asserts on gcref/byref computation (dotnet#56192)

    The emitter has asserts that an xarch RMW inc/dec/add/sub of a byref
    must have an incoming gcref/byref to be legal. This is (no longer)
    true due to extensive use of Span and Unsafe constructs, where we
    often see lclheap or other integer typed values cast to byref. Also,
    the emitter only updates its GC info when an instruction is generated.
    When one of these casts from integer to byref ends up getting the same
    register allocated, and its instruction is thus omitted, the emitter
    doesn't get the appropriate gcref update (this problem is being
    attempted to be solved elsewhere).
    
    For now, disable these asserts.
    
    Re-enable the tests disabled in dotnet#54207
    
    Fixes dotnet#51728, dotnet#54007
    BruceForstall authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    d148c34 View commit details
    Browse the repository at this point in the history
  5. fix SNI handling in quic (dotnet#55468)

    * fix SNI handling in quic'
    
    * cut ServerOptionsSelectionCallback
    
    * feedback from review
    
    * feedback from review
    wfurt authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    5399ee5 View commit details
    Browse the repository at this point in the history
  6. Import local nodes that may need normalization through common path (d…

    …otnet#56044)
    
    Fix issues where we were creating TYP_INT locals that need normalization
    in the importer. This could lead to us to read the wrong number of bytes
    from such locals.
    
    In particular this happened when passing a small-sized parameter as a
    TYP_INT argument, and that call was inlined. We would end up with a
    TYP_INT GT_LCL_VAR node referring to the small parameter that required
    normalization.
    
    This change seems to have some benefit too; in a few situations, it
    seems the old behavior meant that we could not enregister the small
    locals.
    
    Fix dotnet#55143
    jakobbotsch authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    a03a5c8 View commit details
    Browse the repository at this point in the history
  7. Re-enable System.Diagnostics.Tests.DiagnosticSourceEventSourceBridgeT…

    …ests.NoExceptionThrownWhenProcessingStaticActivityProperties (dotnet#56209)
    MaximLipnin authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    92affa2 View commit details
    Browse the repository at this point in the history
  8. Fix: XmlWriterSettings.Encoding must be registered in static Encoding (

    …dotnet#56164)
    
    * Fix: XmlWriterSettings.Encoding must be registered in static Encoding
    
    * Update src/libraries/System.Private.Xml/src/System/Xml/Core/XmlEncodedRawTextWriter.cs
    
    Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
    
    Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
    krwq and buyaa-n authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    fdead97 View commit details
    Browse the repository at this point in the history
  9. Reenable some Android Globalization tests (dotnet#56147)

    Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty.
    
    Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop. Adjusted accordingly.
    
    Fixes dotnet#36672
    steveisok authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    4e47e8c View commit details
    Browse the repository at this point in the history
  10. Add explicit dependency on System.Reflection.Metadata to the RuntimeC…

    …onfigParser task. (dotnet#56152)
    
    This change adds an explicit dependency on System.Reflection.Metadata to the RuntimeConfigParser task when targeting the full .net framework.
    
    Closes: dotnet#55277
    directhex authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    bd3fb96 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1a3a042 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c796482 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0bd7ddc View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    881f3c6 View commit details
    Browse the repository at this point in the history
  15. Supported contained bitcast under STORE_LCL_VAR/FLD on arm32/64. (dot…

    …net#56122)
    
    * Return contained bitcast to arm lowering.
    
    * Supported contained bitcast for arm64.
    
    * support contained bitcast arm32.
    
    * Fix arm32.
    
    * fix
    
    * fix assert
    
    * improve comments
    Sergey Andreenko authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    361184f View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    b12bfc5 View commit details
    Browse the repository at this point in the history
  17. [QUIC] Certificate name validation (dotnet#56175)

    * Shared CertificateValidation and used in S.N.Quic
    
    * adressed feedback
    
    * Post merge
    
    * Added tests
    ManickaP authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    877af80 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    7ff91a0 View commit details
    Browse the repository at this point in the history
  19. Fix iOS/Android InvariantMode functional test (dotnet#56231)

    The android test was not handling CultureNotFoundException and was crashing.
    
    Fixes dotnet#51016
    steveisok authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    a782de1 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    6971186 View commit details
    Browse the repository at this point in the history
  21. Make callouts to interoplib in preemptive mode that can call back int…

    …o runtime (dotnet#56199)
    
    * Make sure all callouts to interoplib that can call back into runtime transition to PREEMPT mode.
    AaronRobinsonMSFT authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    6ebdf24 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2021

  1. Configuration menu
    Copy the full SHA
    4ee01db View commit details
    Browse the repository at this point in the history
  2. Build support for s390x: installers and packages (dotnet#53950)

    * Introduce "PrimaryRuntimeFlavor" concept, set to Mono for s390x
    
    * Enable installers, packages, and archives when building the
      PrimaryRuntimeFlavor, even when this is Mono instead of CoreCLR
    
    * Update default subsets in eng/Subsets.props to take
      PrimaryRuntimeFlavor into account
    
    * Skip packaging singlefilehost when not available (due to building
      with the Mono runtime flavor)
    
    * Only build the IL tools packages in coreclr-packages.proj
      when building with the Mono runtime flavor
    uweigand authored Jul 24, 2021
    Configuration menu
    Copy the full SHA
    c2bd3ca View commit details
    Browse the repository at this point in the history
  3. [WIP] Add new GC Standalone pipeline (dotnet#54024)

    * Add new GC Regions pipeline
    
    * removing osx legs from standalone.
    mangod9 authored Jul 24, 2021
    Configuration menu
    Copy the full SHA
    24fa00d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    78a2b24 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bc0dc07 View commit details
    Browse the repository at this point in the history
  6. Revert Version.TryFormat changes (dotnet#56051)

    * Revert Version.TryFormat changes to use interpolated strings
    
    This was already optimized to use spans directly.  Using our new span-based interpolated string handler was simpler code, but a few more nanoseconds.  Reverting.
    
    * Tweak original code
    
    Make error handling a bit more clear, and use uint formatting rather than int formatting for small perf boost.
    stephentoub authored Jul 24, 2021
    Configuration menu
    Copy the full SHA
    4bf1750 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7d30da6 View commit details
    Browse the repository at this point in the history
  8. HTTP3: Fix issue with GOAWAY handling and implement graceful shutdown…

    … logic in Http3LoopbackServer (dotnet#56134)
    
    * add IsMockProvider/IsMsQuicProvider on QuicTestBase
    
    * add tests for AcceptStreamAsync and Open*Stream when/after the connection is closed/disposed, and related product fixes
    
    * fix issue with GOAWAY handling and add graceful shutdown logic to Http3LoopbackConnection
    
    * PR feedback
    
    Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
    geoffkizer and Geoffrey Kizer authored Jul 24, 2021
    Configuration menu
    Copy the full SHA
    4be9cb3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4651ead View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    003e09e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2021

  1. Configuration menu
    Copy the full SHA
    beaa506 View commit details
    Browse the repository at this point in the history
  2. Cleanup rotate patterns (dotnet#54099)

    * Clean RotateLeft
    
    * Cleanup RotateRight
    huoyaoyuan authored Jul 25, 2021
    Configuration menu
    Copy the full SHA
    d019e70 View commit details
    Browse the repository at this point in the history
  3. Tweak code gen for Guid parsing (dotnet#56210)

    * Tweak code gen for Guid parsing
    
    * Further tweak to use nuint/nint
    stephentoub authored Jul 25, 2021
    Configuration menu
    Copy the full SHA
    ce3e00b View commit details
    Browse the repository at this point in the history
  4. Fix createdump crash on alpine 3.12 and above. (dotnet#56272)

    Finally hit an existing problem in createdump (since 2.1) where the std::set<MemoryRegions> in
    ThreadInfo::GetThreadStack() where it is calling CrashInfo::SearchMemoryRegions with m_crashInfo.OtherMappings()
    which returns a copy of the set of MemoryRegions instead of a reference. On alpine 3.12 musl, this set copy
    is freed right away when it goes out of scope as soon as SearchMemoryRegions returns. On any other Linux distro
    and MacOS the set doesn't get freed/invalidated as soon.
    
    Return references to the threads and memory region sets in the CrashInfo functions.
    mikem8361 authored Jul 25, 2021
    Configuration menu
    Copy the full SHA
    9586375 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Fix Windows build of ds-ipc-pal-socket.c and make FD_CLOEXEC best eff…

    …ort. (dotnet#56141)
    
    Up until dotnet#55850 it was possible
    to build using diagnostic server socket PAL on Windows for local testing.
    NOTE, this is not a config we build on CI since it is not used by any
    products (diagnostic server PAL on Windows uses NamedPipes), but useful
    for local testing.
    
    The same PR also included calls to fcntl using FD_CLOEXEC in case platform
    doesn't define SOCK_CLOEXEC. Since this is a Linux specific flag, it might not
    be defined on several targeted platforms. Failures calling fcntl using
    FD_CLOEXEC was also triggering an EP_ASSERT but that is only on debug
    builds. Most calls to fcntl using FD_CLOEXEC in runtime PAL layers
    (both CoreCLR and MonoVM) doesn't check for errors in this case
    and sees the operation as best effort, like done here
    https://github.com/dotnet/runtime/blob/b937677e8f8601848d29bc072a93cc0c6e21576d/src/libraries/Native/Unix/System.Native/pal_networking.c#L2499.
    We should do the same in ds-ipc-pal-socket.c making sure it won't break
    any potential platform not fully supporting it or if we are really concerned
    about this error, handle it as real error failing creation of socket, but
    that needs to be tested on mobile platforms (not running TCP/IP PAL on CI).
    lateralusX authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    5624e99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c93bb62 View commit details
    Browse the repository at this point in the history
  3. Disable test System.Net.Quic.Tests.MsQuicTests.ConnectWithCertificate…

    …Callback (dotnet#56264)
    
    Disabled test tracked by dotnet#56263
    karelz authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    eb4be08 View commit details
    Browse the repository at this point in the history
  4. Disable test ResponseCancellation_ServerReceivesCancellation (dotnet#…

    …56291)
    
    Test: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic.ResponseCancellation_ServerReceivesCancellation
    
    Disabled test tracked by dotnet#56194
    karelz authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    7d45278 View commit details
    Browse the repository at this point in the history
  5. Keep X509 handle alive while in use when reading certificate data (do…

    …tnet#56277)
    
    * Add test for thread racing certificate usage and disposal
    
    * Implement changes to keep the X509* alive while in use.
    vcsjones authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    10c2383 View commit details
    Browse the repository at this point in the history
  6. Adjust exception message for headers having non-ASCII chars (dotnet#5…

    …5886)
    
    Reuse existing resource string.
    
    Fixes dotnet#55310
    pedrobsaila authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    158fc37 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1dc2ab4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    513fa6c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    49d8889 View commit details
    Browse the repository at this point in the history
  10. Implement new way of return address hijacking (dotnet#55946)

    * Implement new way of return address hijacking
    
    This change implements a new way of return address hijacking for Intel
    CET enabled Windows devices. It uses a mechanism created by the Windows
    team for this purpose. The existing mechanism that just patches the
    return address by an address of our helper routine would result in
    process killing as it would seem like a ROP exploit.
    janvorli authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    51886d1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    567e7c3 View commit details
    Browse the repository at this point in the history
  12. Use more ReadOnlySpan<byte>s in `System.Reflection.MetadataLoadCont…

    …ext` (dotnet#56207)
    
    * Use spans instead of byte arrays in `MetadataLoadContext.Utf8Constants`.
    
    * Optimize Helpers.ToUtf16(ReadOnlySpan<byte>).
    
    It avoids a byte array allocation on all frameworks.
    And remove an unused overload of it.
    
    * Address PR feedback.
    
    * Fix ArgumentNullExceptions.
    teo-tsirpanis authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    b00a64a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0c20095 View commit details
    Browse the repository at this point in the history
  14. Fix error message when publishing logs in Restore internal tools step (

    …dotnet#56307)
    
    In https://dev.azure.com/dnceng/internal/_build/results?buildId=1250178&view=results we hit an issue where the 'Restore internal tools' step failed, but AzDO only highlights the failure in the 'Publish Logs' step because the directory didn't exist.
    This happens because the restore step was not passing along the build configuration so it defaults to Debug instead of Release, leading to the log directory we try to publish not existing.
    akoeplinger authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    eec3122 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    a2235e7 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a85d36f View commit details
    Browse the repository at this point in the history
  17. Change MonoProfiler provider GUID to be based on algorithm used by Tr…

    …aceEvent library. (dotnet#56286)
    
    TraceEvent uses an algorithm defined in http://www.ietf.org/rfc/rfc4122.txt
    to get an EventSource GUID from its name. This is used for newer EventSource
    providers, and doesn't need changes to TraceEvent code to be detected.
    
    This commit adjust MonoProfiler EventSource provider GUID to the version
    calculated by that algorithm.
    lateralusX authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    d62117f View commit details
    Browse the repository at this point in the history
  18. Include time taken on DNS queue in events (dotnet#56208)

    * Include time taken on DNS queue in events
    
    * Add test
    
    * Add usings
    
    * More usings
    
    * Move Assert out of EventListener callback
    MihaZupan authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    6696065 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    a336536 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    09e1608 View commit details
    Browse the repository at this point in the history
  21. Remove crossgen comparison jobs (dotnet#56193)

    - We no longer have crossgen
    - The jobs didn't detect that failure and have been wasting CPU time on every PR
    davidwrighton authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    6168c4a View commit details
    Browse the repository at this point in the history
  22. Upgrade to msbuild version 16.10 (dotnet#56025)

    * Fixes dotnet#54826
    
    * Adjust net472 dependencies of Microsoft.NETCore.Platforms.Tests
    uweigand authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    2f2ed39 View commit details
    Browse the repository at this point in the history
  23. Fix for issue 55241 (dotnet#56230)

    Don't decrement our budget once we have reached 0
    briansull authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    16b4564 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Configuration menu
    Copy the full SHA
    62503dd View commit details
    Browse the repository at this point in the history
  2. Fix .vsconfig (dotnet#56339)

    * Fix .vsconfig
    
    * Remove vs2022 only item
    danmoseley authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    4143ac3 View commit details
    Browse the repository at this point in the history
  3. quic test improvements (dotnet#56043)

    * quic test improvements
    
    * fix incorrect use of PassingTestTimeout
    
    * feedback from review
    wfurt authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    66d23a7 View commit details
    Browse the repository at this point in the history
  4. Split mobile specific ILLink.Substitutions into its own file (dotnet#…

    …56306)
    
    It was discovered in dotnet#56161 that mobile specific HttpClientHandler substitutions were sticking around even for non mobile builds. This change moves the substitution into ILLink.Substitutions.mobile.xml.
    steveisok authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    2b3f76c View commit details
    Browse the repository at this point in the history
  5. Update SR.cs (dotnet#56332)

    Tratcher authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    c86fd4e View commit details
    Browse the repository at this point in the history
  6. Fix an error printed out when install_location file is missing (dotne…

    …t#56327)
    
    The app will still run, but we must not print out anything in that case.
    
    Fixes dotnet#56219
    vitek-karas authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    5397d30 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    08605bf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7545f98 View commit details
    Browse the repository at this point in the history
  9. Skip environment variable access calls for non OSX apple platforms (d…

    …otnet#56320)
    
    Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
    mdh1418 and Mitchell Hwang authored Jul 27, 2021
    1 Configuration menu
    Copy the full SHA
    2053d65 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b94d94a View commit details
    Browse the repository at this point in the history
  11. Display class names and string literals in asm (dotnet#55970)

    Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
    EgorBo and kunalspathak authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    578f81a View commit details
    Browse the repository at this point in the history
  12. Add timeouts to IPInterfaceProperties tests (dotnet#56319)

    * Add timeouts to IPInterfaceProperties tests
    
    * Use common Timeout value and Xunit output helper
    
    * Add Threading.Tasks using
    MihaZupan authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    2d0d590 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    9d9b465 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b9e3c72 View commit details
    Browse the repository at this point in the history
  15. Disable test SendAsync_WithZeroLengthHeaderName_Throws (dotnet#56363)

    Test: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic.SendAsync_WithZeroLengthHeaderName_Throws
    
    Disabled test tracked by dotnet#56292
    karelz authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    f32b55f View commit details
    Browse the repository at this point in the history
  16. Tighten up some ArrayPool.Return usage (dotnet#56229)

    Avoid potential problems if Return were to throw an exception after having already put the array back into the pool.
    stephentoub authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    59a5610 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    34094b3 View commit details
    Browse the repository at this point in the history
  18. Skip finalizer test if precise GC is not supported (dotnet#56364)

    * Finalizer_OperationNotCompleted_CompletesOperation assumes precise GC
    uweigand authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    6a5eaed View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    a61bc64 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    4936cae View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    6192f0c View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    95f4fd0 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    72393ff View commit details
    Browse the repository at this point in the history
  24. avoid ReadFile syscall if we know that there is nothing to read from …

    …file (dotnet#56387)
    
    * avoid ReadFile syscall if we know that there is nothing to read from file
    
    * Apply suggestions from code review
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    adamsitnik and stephentoub authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    c81ca16 View commit details
    Browse the repository at this point in the history
  25. Update CG2 ArgIterator to match the runtime one (dotnet#56059)

    * Update CG2 ArgIterator to match the runtime one
    
    The goal of the change is primarily to make it correct for the Apple
    Silicon where the calling convention slightly differs from the
    Unix ARM64 one, especially in passing arguments smaller than a pointer
    size on stack.
    janvorli authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    bf5fe8c View commit details
    Browse the repository at this point in the history
  26. Fix thread pool hang (dotnet#56346)

    * Fix thread pool hang
    
    - In dotnet#53471 the thread count goal was moved out of `ThreadCounts`, it turns out that are a few subtle races that it was avoiding. There are other ways to fix it, but I've added the goal back into `ThreadCounts` for now.
    - Reverted PR dotnet#55985, which worked around the issue in the CI
    
    Fixes dotnet#55642
    
    * Revert "mitigation for quic tests hangs (dotnet#55985)"
    
    This reverts commit 0a5e93b.
    kouvel authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    eaaf43f View commit details
    Browse the repository at this point in the history
  27. JIT: more fixes for VN loop dependence tracking (dotnet#56184)

    Specify `Overwrite` when setting loop dependence map entries, as we may
    refine the initial result.
    
    Fixes dotnet#56174.
    
    Extract loop dependence of `VNF_PhiMemoryDef`.
    
    Fixes new case noted in dotnet#55936, and 13/16 or so other cases Jakob sent
    me privately. Also update a comment and fix tests to work better with
    jitstress per other notes on that PR.
    AndyAyersMS authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    b18ff29 View commit details
    Browse the repository at this point in the history
  28. Add tests for reads and writes beyond EOF (dotnet#56395)

    * ensure that reads beyond EOF return 0
    
    * ensure that writes beyond EOF extend the file and the content is zeroed
    adamsitnik authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    eeb4f36 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    59e7258 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    d61aeca View commit details
    Browse the repository at this point in the history
  31. Have HttpClientHandler throw the InnerException when catching TargetI…

    …nvocationException (dotnet#56334)
    
    Originally on mobile workloads when UseNativeHttpHandler is set to true, all reflection method invokes
    bubbled up a TargetInvocationException.  To make the details a bit more readable, we will instead rethrow
    the InnerException.
    
    Fixes dotnet#56089
    steveisok authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    baf0cd8 View commit details
    Browse the repository at this point in the history
  32. Remove ActiveIssues from tests no longer failing (dotnet#56393)

    Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
    mdh1418 and Mitchell Hwang authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    ee729c8 View commit details
    Browse the repository at this point in the history
  33. [libraries][iOS][tvOS][MacCatalyst] Remove ActiveIssue from no longer… (

    dotnet#56401)
    
    * [libraries][iOS][tvOS][MacCatalyst] Remove ActiveIssue from no longer failing Microsoft.Extensions.Hosting.Unit.Tests
    
    * Remove StopAsyncWithCancellation Active Issue as well
    
    Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
    mdh1418 and Mitchell Hwang authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a51d484 View commit details
    Browse the repository at this point in the history
  34. Remove invalid Castle.DynamicProxy.Internal.AbstractInvocation from I…

    …LLink descriptor files (dotnet#56392)
    
    The type is actually in the `Castle.DynamicProxy` namespace, not the `.Internal` one.
    This causes an error with newer linker versions.
    
    The whole `Castle.DynamicProxy` namespace is already preserved so we can remove the entry for AbstractInvocation.
    akoeplinger authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    5938d68 View commit details
    Browse the repository at this point in the history
  35. Fix MetricsEventSource tests (dotnet#56382)

    Last week I added a change to the error handling behavior when MetricEventSource
    is enabled by multiple listeners and didn't properly update the tests.
    1. The major issue was timout failures which were being caused because there is
    a bug in EventListener where it doesn't notify EventSources that the source has
    been disabled when the listener is disposed. This in turn caused every tests after
    the first to reject the new EventListener because the EventSource believed it was
    still in use by the first EventListener.
    (EventListener bug is tracked dotnet#56378)
    2. A secondary issue is that I didn't update the test which was explicitly verifying
    the behavior where the EventSource emits an error in response to having two
    listeners and I had changed the product behavior there.
    
    Fixes:
    1. I worked around the EventListener bug by explicitly calling DisableEvents().
    I also updated OnEventWritten to log the MultipleSessionsNotSupportedError
    so that any future error that is similar has more obvious diagnostic logging.
    2. I updated the test with new expectation that the 1st listener continues normal
    operation and the 2nd listener is the one that gets rejected.
    
    I also did a little refactoring and added a 2nd tests of multiple listeners to confirm
    it works if the first one is disabled before the 2nd one starts.
    noahfalk authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    392ff31 View commit details
    Browse the repository at this point in the history
  36. Try to fix finalizer-based async tests (dotnet#56384)

    A dump from a failure showed the finalizable object we're relying on was unrooted and waiting for finalization.  Issue more Collects to see if that helps.
    stephentoub authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    cc12918 View commit details
    Browse the repository at this point in the history
  37. Fix FailFast message formatting race (dotnet#56388)

    * Fix FailFast message formatting race
    
    SystemNative::GenericFailFast uses a global buffer for messages shorter than certain size.
    When multiple threads call FailFast at the same time, they all use the same buffer,
    overwriting each other's message. That leads to a problem on Unix when the message is
    converted to UTF-8 using two calls to WideCharToMultiByte and another thread changes
    the message to a longer one between those two calls. So the buffer size the first
    call determines is no longer sufficient.
    janvorli authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    2e10087 View commit details
    Browse the repository at this point in the history
  38. Specify win-x64 as a valid platform in the microsoft-net-runtime-* wo…

    …rkloads for iOS/tvOS/MacCatalyst (dotnet#56311)
    
    In a prior change, win-x64 was specified for runtimes-*, but it is also needed in the other workloads
    steveisok authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    2a3141a View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    2a02896 View commit details
    Browse the repository at this point in the history
  40. Update runtimeconfig.json and deps.json paths when these break past t…

    …he MAX_PATH threshold (dotnet#56224)
    
    * Update runtimeconfig paths if we exceed MAX_PATH
    
    * Add test
    
    * PR feedback
    
    * Get apphost for all platforms
    
    * Probe bundle first
    Fix return value of realpath
    
    * Check for empty path upfront
    mateoatr authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    866808d View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    598c2da View commit details
    Browse the repository at this point in the history
  42. Fix type loader not recognizing overridden method (dotnet#56337)

    * Fix type loader not recognizing overridden method
    - Result of a bad change when removing support for full stub dispatch in .NET 4.0 timeframe (circa 2008)
    - Caused issue when the following set of conditions were all true
      - The type implements an interface
      - The interface has more virtual methods on it than the number of virtual methods on the base type of the type.
      - The base type implements the interface partially (and the partial implementation has a slot number greater than the number of virtual methods on the base type + its base types)
      - The type does not re-implement the interface methods implemented by the base type.
    - The comment referred to situations where stub dispatch was used to resolve non-virtual calls which is a very long time removed feature and is not applicable to today's codebase.
    - Not reachable with versions of C# that shipped before the default interfaces feature, but with that feature became easily reachable. Has been a bug since .NET 4 for handwritten IL.
    
    Fixes dotnet#44533
    davidwrighton authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    3ce1168 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Configuration menu
    Copy the full SHA
    ddc729f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7424613 View commit details
    Browse the repository at this point in the history
  3. Fix comments in asm with JitDiffableDasm=1 (dotnet#56416)

    * Avoid asserts in DasmDiffable mode
    
    * simplify
    
    * Make formatter happier
    
    * Address feedback
    EgorBo authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    8ed7f57 View commit details
    Browse the repository at this point in the history
  4. Fix dependency from EventLog to TraceSource ref (dotnet#56417)

    * Fix dependency from EventLog to TraceSource ref
    
    This regressed with dotnet@663c40d. Reference projects should never reference source projects. This is one of the reasons why slngen creates different solution files now.
    
    * Update Microsoft.Extensions.DependencyInjection.Abstractions.csproj
    ViktorHofer authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6d97b44 View commit details
    Browse the repository at this point in the history
  5. Make open function calls in coreclr EINTR resilient on macOS (dotnet#…

    …56403)
    
    It was reported that on macOS, the open syscall can sometimes
    return EINTR if it is interrupted by a signal even if the
    signal has a handler installed with SA_RESTART.
    
    There was just one call to open in the coreclr that
    didn't have EINTR handled and that can be called on macOS, so
    this change fixes it.
    
    There are two places in the libraries in the included 3rd party
    code - the brotli and the zlib - that don't have this treatment yet.
    We may want to update them unless the policy we have for them is
    to make changes upstream.
    janvorli authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    504f1e8 View commit details
    Browse the repository at this point in the history
  6. Properly rebuild optimization data when it changes (dotnet#56397)

    The timestamp of the merged .mibc file was set to when the tool was
    invoked, while the inputs have a timestamp from when they were created
    in the training scenarios. That means the target to create the merged
    .mibc file would not run incrementally until many weeks later.
    
    To fix add an --inherit-timestamp flag to dotnet-pgo that makes the
    merged output inherit the max timestamp from the inputs. This is not
    ideal as it means incrementally going backwards does not work, but it's
    better than the previous behavior.
    
    Fix dotnet#53637
    jakobbotsch authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    cf52b7e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b209dec View commit details
    Browse the repository at this point in the history
  8. [mono] Add GC unsafe transition to mono_unhandled_exception (dotnet#5…

    …6380)
    
    * Fix assert gc_unsafe.
    
    * Update src/mono/mono/metadata/object.c
    
    Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
    
    Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
    thaystg and lambdageek authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    5ade773 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e0f8fff View commit details
    Browse the repository at this point in the history
  10. Update dependencies from https://github.com/mono/linker build 2021072…

    …6.2 (dotnet#56374)
    
    Microsoft.NET.ILLink.Tasks
     From Version 6.0.100-preview.6.21370.1 -> To Version 6.0.100-preview.6.21376.2
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    d1b866e View commit details
    Browse the repository at this point in the history
  11. Disable test ConnectWithCertificateForDifferentName_Throws (dotnet#56456

    )
    
    Test: System.Net.Quic.Tests.MsQuicTests.ConnectWithCertificateForDifferentName_Throws
    
    Disabled test tracked by dotnet#56454
    karelz authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6c64d2e View commit details
    Browse the repository at this point in the history
  12. Fix for issue 56200 (dotnet#56261)

    Use InternalFormat when formatting an integer
    value as an Enum that uses the FlagsAttribute.
    
    Fix dotnet#56200
    
    Co-authored-by: cvicary <cvicary@ea.com>
    ChrisVicary and cvicary authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    7ed2959 View commit details
    Browse the repository at this point in the history
  13. Add Android 31 and iOS/tvOS/MacCatalyst 15 to RID graph (dotnet#55933)

    These OS versions will go stable later this summer.
    akoeplinger authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    8fdf146 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    911edf6 View commit details
    Browse the repository at this point in the history
  15. Build runtime.native.System.IO.Ports on linux-s390x (dotnet#56424)

    * Add RID to runtime.native.System.IO.Ports/netcoreapp.rids.props
    
    * Update runtime.native.System.IO.Ports.pkgproj file.
    uweigand authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    5d2229e View commit details
    Browse the repository at this point in the history
  16. Introduce new AddEventListener and RemoveEventListener APIs on JSObje…

    …ct (dotnet#55849)
    
    Introduces new AddEventListener and RemoveEventListener methods on JSObject that create a delegate wrapper with its lifetime managed by the JavaScript GC instead of managed types, to ensure that delegates don't go away while JS is still using them. Migrates BrowserWebSocket to use the new APIs.
    kg authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    a3ddef1 View commit details
    Browse the repository at this point in the history
  17. Remove MONO_IOMAP / portability from mono (dotnet#56458)

    It's not used in netcore mono (since it only works in mono but not the PAL) and judging by the discussion in dotnet#35299 the consensus is that we should not bring that feature back.
    akoeplinger authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6789379 View commit details
    Browse the repository at this point in the history
  18. Fix Neutral Culture Names (dotnet#56321)

    * Fix Neutral Culture Names
    tarekgh authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    141bd34 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    ec2d25c View commit details
    Browse the repository at this point in the history
  20. Update libraries solution and NuGet.config files (dotnet#56430)

    * Update slngen and invocation
    
    * Update NuGet.config files
    
    * Update solution files with slngen
    ViktorHofer authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    a6b9a63 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    c0cad5f View commit details
    Browse the repository at this point in the history
  22. Add validation for MetadataType attribute - Issue dotnet#46678 (dotne…

    …t#51772)
    
    * MetadataType attribute class properties are now validated.
    
    Fix dotnet#46678
    
    * Clean up PR dotnet#51772
    
    Co-authored-by: Brice Lambson <brice@bricelam.net>
    Xaeco and bricelam authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    5d42771 View commit details
    Browse the repository at this point in the history
  23. Re-enable System.IO.FileSystem.DriveInfoTests.DriveInfoUnixTests.Prop…

    …ertiesOfValidDrive on Android (dotnet#56462)
    
    Contributes to dotnet#42548.
    
    Based on akoeplinger's suggestion dotnet#42209 (comment)
    MaximLipnin authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    fe4d5cf View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    f5a7304 View commit details
    Browse the repository at this point in the history
  25. Build support for s390x: corehost (dotnet#53949)

    * Build the (non-Windows) host binaries with either runtime flavor
    
    * s390x architecture support in get_arch utility
    uweigand authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    db1b302 View commit details
    Browse the repository at this point in the history
  26. JIT: properly update loop memory dependence when loops are removed (d…

    …otnet#56436)
    
    If a loop is removed (because of unrolling) then the loop dependence
    tracking introduced in dotnet#55936 and dotnet#56184 may not properly update.
    
    So when a loop is removed, walk up the chain of parent loops looking
    for one that is not removed, and record the dependence on that parent.
    
    Addresses last part of dotnet#54118.
    AndyAyersMS authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    b25bd29 View commit details
    Browse the repository at this point in the history
  27. Assert if we find undefined use during interval validation (dotnet#56439

    )
    
    * Assert if we find undefined use during interval validation
    
    * Include lastUse check
    kunalspathak authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    ca908f5 View commit details
    Browse the repository at this point in the history
  28. Update area-owners.md (dotnet#56481)

    * Update area-owners.md
    
    added area-codeflow so that maestro PR's don't make noise by tagging the infrastructure areas.
    
    * Update area-owners.md
    danmoseley authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    5d03d42 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    cd1b4cf View commit details
    Browse the repository at this point in the history
  30. EventSource Manifest Trimmer test (dotnet#56463)

    * EventSource Manifest Trimmer test
    
    * FB
    LakshanF authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    beaea95 View commit details
    Browse the repository at this point in the history
  31. Fix redhat arm64 (dotnet#52244)

    * Fix RHEL 8 ARM64
    
    Clang on ARM64 places the .rodata section into the same segment
    as .text. On RHEL 8 ARM64, the kernel is configured for 64kB
    memory pages. When we flip the page protection of the page containing
    the GS cookie to RW and back to RO, we assume that the cookie lives
    in a non-executable memory. This assumption is broken on RHEL 8 and
    we end up setting protection of a part of the coreclr code to read
    only instead of back to RX.
    
    This change switches the linker we use to lld from the previously
    used gnu linker. That linker places .rodata into a different segment
    than .text by default. Moreover, I was planning to move to using
    lld anyways to use all build tools from LLVM.
    
    * Fix ARM build to use PC relative addresses only
    
    The lld linker has revealed that we were using absolute addresses in some
    asm helpers and so load time relocation was necessary. This change fixes
    it by replacing all of those by PC relative ones.
    
    * Update docker images used for building runtime
    
    Use new images that have lld linker
    
    * Disable lld linker for s390x
    janvorli authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    39803d4 View commit details
    Browse the repository at this point in the history
  32. [wasm] Fix Publish for Blazorwasm projects on VS17 (dotnet#56432)

    TL;dr `publish` fails on any blazorwasm project with VS17
    
    A recent commit[1] moved initializing `$(_WasmIntermediateOutputPath)` from
    a target, to project level `PropertyGroup`. It is set as:
    
    `<_WasmIntermediateOutputPath>$([MSBuild]::NormalizeDirectory($(IntermediateOutputPath), 'wasm'))</_WasmIntermediateOutputPath>`
    
    The `NormalizeDirectory` call converts this to a full path, presumably
    using the current directory.
    
    Because we are setting `$(_WasmIntermediateOutputPath)` at the project
    level, it gets evaluated during the evaluation phase. And the current
    directory doesn't seem to be set to the project directory at that point
    in VS. So, `$(_WasmIntermediateOutputPath)` gets a wrong path like:
    
    `C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\IDE\obj\Release\net6.0\wasm`.
    
    And then when actually publishing, it fails to create this directory
    with:
    
    `Unable to create directory "C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\IDE\obj\Release\net6.0\wasm\". Access to the path 'C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\IDE\obj\Release\net6.0\wasm\' is denied.`
    
    Fix:
    Set the property in `_InitializeCommonProperties` *target*, at which
    point the current directory is correctly set.
    
    Note:
    - This doesn't seem to be reproducible outside VS
    - It happens only on `publish`, because that's when the wasm targets
      come into play.
    
    --
    1.
    ```
    commit d574b03
    Author: Ankit Jain <radical@gmail.com>
    Date:   Mon Jul 19 01:02:01 2021 -0400
    
        [wasm] Add support for using custom native libraries (dotnet#55797)
    ```
    radical authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    7b3e22b View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    c62ece8 View commit details
    Browse the repository at this point in the history
  34. RefTypeZeroInit doesn't need treeNode (dotnet#56333)

    * RefTypeZeroInit doesn't need treeNode
    
    * Add a test case
    kunalspathak authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6d35185 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Covariant return updates to ecma augments (dotnet#56496)

    * Covariant return updates to ecma augments
    davidwrighton authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    5d4d913 View commit details
    Browse the repository at this point in the history
  2. Validate ref project references (dotnet#56488)

    * Validate that reference assembly projects only reference other reference assembly projects
    
    * Permit ref->src reference if src project produces reference assembly
    
    * Move target to references.targets
    ericstj authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    dc36fce View commit details
    Browse the repository at this point in the history
  3. Reenable DiagnosticSource tests (dotnet#56500)

    A few years ago this test was timing out on ARM64 because of hardware
    constraints. I am re-enabling the test to see if this is still an issue
    or if the situation has been resolved since then.
    noahfalk authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    8cf9591 View commit details
    Browse the repository at this point in the history
  4. Fix EventSource shutdown deadlock (dotnet#56453)

    Fixes dotnet#48342
    
    A deadlock was occuring because we held the EventListenersLock
    while calling into EventUnregister which will take ETW's own native
    lock. In the case of ETW sending an enable/disable notification
    these locks are taken in reverse order which triggers a deadlock.
    
    The fix is to ensure that we always order the locks so that any code
    path taking both locks always takes the ETW lock first. In this case
    it meant accumulating the list of event sources to dispose under
    the lock but then exiting the lock prior to calling Dispose() which
    will eventually call EventUnregister.
    noahfalk authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    6482d14 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d0f2752 View commit details
    Browse the repository at this point in the history
  6. Support 8-byte alignment for 12-byte structs on ARM32 (dotnet#56375)

    * Support 8-byte alignment for 12-byte structs on ARM32
    
    Through explicit attributes it is possible that 8-byte aligned structs
    are 12 bytes in size, so handle this in arm32 when we figure out if we
    need an extra spill to keep the alignment.
    
    Fix dotnet#42723
    
    * Add a regression test
    jakobbotsch authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    51040e6 View commit details
    Browse the repository at this point in the history
  7. avoid NRE in MsQuicConnection ConnectAsync (dotnet#56283)

    * avoid NRE in MsQuicConnection ConnectAsync
    
    * enable disabled test
    
    * one more place where we set ConnectTcs to null
    
    * use local variable
    
    * feedback from review
    wfurt authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    87769fb View commit details
    Browse the repository at this point in the history
  8. Pass excludemonofailures in managed test build job for mono (dotnet#5…

    …6434)
    
    * Pass excludemonofailures in managed test build job for mono
    * Make test build scripts pass RuntimeFlavor when building tests (not just wrappers)
    elinor-fung authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    a943e37 View commit details
    Browse the repository at this point in the history
  9. Use Ubuntu instead of macOS pool for evaluate-paths-job.yml (dotnet#5…

    …6479)
    
    The script can run on Ubuntu as well so we can take some work off of the congested macOS pool.
    
    Also set a fetch depth of 2 since that's all we need to calculate the changed paths, this shaves ~40 seconds off that step.
    akoeplinger authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    451909b View commit details
    Browse the repository at this point in the history
  10. Fix two issues with budget smoothing: (dotnet#56467)

    - We smoothed budgets *across* LOH and POH by mistake
    - We didn't do any budget smoothing for LOH and POH in background GCs.
    PeterSolMS authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    d86299e View commit details
    Browse the repository at this point in the history
  11. Remove Reflection.Emit APIs (dotnet#56153)

    * Remove Reflection.Emit APIs
    
    Removes all unused leftover APIs
    
    Fix dotnet#49452
    
    * Fix the api-compat baseline
    
    * Remove the baseline altogether
    
    * Remove fIsTransient refs from .cpp (as well as .h)
    
    * Remove nIsTransientInternal
    
    * Remove DefineDynamicModule & DefineDocument
    
    * Revert "Remove the baseline altogether"
    
    This reverts commit ddb0303.
    
    * API compat baseline for GetModuleHandleImpl
    
    * Fix Mono
    
    * Match changes in Mono runtime
    i3arnon authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    742ea07 View commit details
    Browse the repository at this point in the history
  12. Disable test ResponseHeadersRead_SynchronizationContextNotUsedByHandl…

    …er for WinHttpHandler on Win7/Win81 (dotnet#56490)
    
    Disable test ResponseHeadersRead_SynchronizationContextNotUsedByHandler for WinHttpHandler on Win7/Win81
    Test types:
    - System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_Asynchrony_Test
    - System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_Asynchrony_Http2_Test
    
    Disabled test tracked by dotnet#54034
    karelz authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    3c253d1 View commit details
    Browse the repository at this point in the history
  13. Fix the build of a couple SLNs (dotnet#56483)

    Build in VS was broken because of missing projects from SLN and VS
    attempting to call GetTargetPath on outer build of AnalyzerReference projects.
    ericstj authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    8b87ada View commit details
    Browse the repository at this point in the history
  14. [libraries][Android] Re-enable test suites no longer failing with JSO…

    …N parsing exception for Android arm64 (dotnet#56411)
    
    * Temporarily remove test suites from proj level skip to evaluate JSON parsing
    
    * Temporarily enable tests ran on this draft PR
    
    * Remove temporary disabling of arm lanes for Android runtime-staging
    
    Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
    mdh1418 and Mitchell Hwang authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    5285a89 View commit details
    Browse the repository at this point in the history
  15. [mono] remove redundant DISABLE_PERF_COUNTERS option (dotnet#56420)

    * [mono] remove redundant DISABLE_PERF_COUNTERS option
    
    There is already a `DISABLE_PERFCOUNTERS` option, which is always set in src/mono/CMakeLists.txt
    
    * fix log profiler in Android builds
    lambdageek authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    65de909 View commit details
    Browse the repository at this point in the history
  16. Revert "JIT: Drop redundant static initializations from (Equality)Com…

    …parer<T>.Default (dotnet#50446)" (dotnet#56400)
    
    This reverts commit 46e5fe1.
    EgorBo authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    a036594 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    a8dacd5 View commit details
    Browse the repository at this point in the history
  18. [debugger] Improve debug after hot reload (dotnet#55869)

    * Creating more test for hot reload debugging.
    
    * Fixing step on android after hot reload.
    
    * Fix get document information from enc pdb.
    
    * Addressing Aleksey comments.
    
    * Addressing @lambdageek comments and fixing implementation of mono_ppdb_lookup_location
    
    * Fixing compilation on ios.
    
    * Fix android compilation.
    thaystg authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    3ffd963 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    eb0b60e View commit details
    Browse the repository at this point in the history
  20. Fix IsolatedStorage initialization on Android (dotnet#56534)

    Android doesn't set an entry assembly so we need to handle that case.
    
    Fixes dotnet#52332
    akoeplinger authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    beeafa0 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    7103f0f View commit details
    Browse the repository at this point in the history
  22. JIT: fix pred list maintenance during fgUpdateFlowGraph (dotnet#56509)

    Handle case where a BBJ_COND block both falls through and branches to
    another block, and we want to introduce a block to re-route the fall through.
    
    Closes dotnet#56495.
    AndyAyersMS authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    705bbfd View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    bcae295 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    108fcdb View commit details
    Browse the repository at this point in the history