vets-api/v0.0.1378

Release 0.0.1378 ami-0dc0263114ce22db0

b27ad9c Ruby 3 KwArgs: Fix HCA Validations spec (#12006)

49f937e Removed VAOS v0 limits controller, VAOS V0 limit serializer and VAOS V0 routing rspecs (#12007)

• removed vaos v0 limits controller limit serializer and routing rspecs

817ec2d Don't set vaCompensationType when disability rating is nil (#11930)

• return from prefill_compensation_type if disability rating is nil

• lint

db0bdb1 try converting to json (#12012)

a42b255 Reverts v2 healthcheck updates (#12005)

7c86018 [53040] Mocked Authentication authorize route setup (#11867)

• mock_authorization authorize route setup

• moves mocked_authentication to module

• spec update

• spec updates

• spec updates

• mocked auth service work

• rubocop path fix

• syntax fix

• removes unneeded instance variable usage

f0f4b17 [45352] remove MHV Accounts / Terms & Conditions (#11922)

• initial removal

• restores terms & conditions

• remove mhv_account from terms_and_conditions_acceptance & swagger

• spec fix

• removes mhv account from redis & mhv_account_ineligible

• removes account_statistics_job_spec

vets-api/v0.0.1377

Release 0.0.1377 ami-0c1cf7207ca8cdf48

f82b8b0 Ruby 3 KwArgs: Fix Caregivers Assistance controller spec (#11993)

Resolves department-of-veterans-affairs/va.gov-team#54272

00c3281 Bump Rack to 2.2.6.3 (#11999)

42d97a8 39154 pt1 remove v0 implementations from vets api v0 facilities controller (#11990)

• removed vaos v0 facilities controller impl and rspecs, partial

5fdda82 fix metadata mapping (#12001)

00a98fb [54398] Increase delay between 686c and 674 form submissions. (#11998)

• Increase delay between 686c and 674 form submissions

Long ago, in #7811, a two-minute delay was set between BGS::SubmitForm686cJob and BGS::SubmitForm674Job, in an attempt to avoid a race condition that produced null dependency claims. The race condition is still occuring, so as a short-term fix, this PR increases the delay to five minutes. Here's some more detail on that issue, and the short-term fix implemented here:

• When a vet submits their form on VA.gov, we sometimes enqueue a job to submit a 686c form to BGS and another job to submit a 674 form to BGS.
• Both of these jobs, among other things, first fetch an incremental from BGS via a findBenefitClaimTypeIncrement endpoint, and then submit this incremental along with the vet's form data to BGS via a insertBenefitClaim endpoint. The incremental is akin to an incrementing ID or serial number. It starts at "130" for each veteran, and every time a veteran makes a successful request to the insertBenefitClaim endpoint, the increment increases by 1. So the next time a veteran consumes the findBenefitClaimTypeIncrement endpoint, they will get an incremental of "131."
• BGS requires every veterans' requests to the insertBenefitClaim endpoint to have a unique incremental. In other words, a veteran cannot make two requests to insertBenefitClaim with the same incremental. If they do, a null dependency claim is generated and a "Duplicate Benefit Claims found on the Corporate Database" error is thrown. This is why VA.gov's 686c and 674 submission jobs are both written to fetch the next incremental from the findBenefitClaimTypeIncrement before consuming the insertBenefitClaim endpoint.
• But here's what VA.gov gets wrong: sometimes we run the 674 job before the 686c submission is complete. Meaning, we ask for 674's incremental before it has been updated by 686c's submission request. Consequently, both submission requests use the same incremental, and the latter request fails, thereby producing a null claim.
• In #7811, previous devs tried to avoid this issue by scheduling the 674 job to run two minutes after enqueueing the 686c job. But, given the large volume of null dependency claims we have been seeing, two minutes is not enough.
• A short term fix for this issue is to increase that two minute delay to a five minute delay. That's what I've done here. This should dramatically reduce the number of null dependency claims, but there will still be a remote possibility that null claims will be created.
• A better, long-term fix will be to re-write the code to force the two jobs to run consecutively. I recommend doing that some time in the near future.

085a6ef Bump rubocop-rails from 2.17.4 to 2.18.0 (#11902)

• Bump rubocop-rails from 2.17.4 to 2.18.0

Bumps rubocop-rails from 2.17.4 to 2.18.0.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
  ...

Signed-off-by: dependabot[bot] support@github.com

• Use exclude instead of inverting include

• Use instead of inverting

• Use instead of inverting .

• Use instead of inverting

• Use instead of inverting .

---

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan Johnson ryan.johnson@oddball.io

37bbfd0 Ruby 3 KwArgs: Monkeypatch ApiVore (#12003)

552b621 removed remainder of vaos v0 facilities request spec (#12004)

vets-api/v0.0.1376

Release 0.0.1376 ami-0f85acd0758b1f5e8

02ccaf7 Ruby 3 KwArgs: MHV (#11959)

4260c8d Ruby 3 upgrade: fix DetailedSchemaErrors spec failures (#11983)

• fix DetailedSchemaErrors spec failures

• Alternative resolution for modifying frozen hash

---

Co-authored-by: Eric Boehs eric@boehs.com

210773a Ruby 3 KwArgs: Credential_level_creator (#11965)

a760421 [11945] Schema change to add logout redirect url to client config (#11963)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io

295d967 53955 add feature flag for precheckin to checkin handoff (#11912)

4062a3a Ruby 3 KwArgs: SAML SSOE (#11954)

Ruby 2.7 deprecated automatic casting of a hash passed as the last argument of a method to keyword arguments. You must now use actual keyword arguments (foo(bar: 'baz') instead of foo({bar: 'baz'})) or cast the hash to keyword args using the double splat (foo(**{bar: 'baz'})).

In preparation for upgrading to Ruby 3.0, we're implementing the new syntax for SAML error classes.

79b7710 resolve csrf vulnerability (#11986)

3eba82d Remove Providers Controller in VAOS (#11979)

• remove providers controller, not used

4fb4850 [22988] Making UserAttributeError initialization more clear (#11989)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io

2e9d835 Testing argocd cron job (#11985)

• Testing argocd cron job

758b244 Ruby 3 KwArgs: Session Controller & SAML SSOE (#11992)

49cad83 Make Supplemental Claim form v3 available (#11987)

Adds a new Flipper flag, decision_review_supplemental_claim_pdf_v3,
which will cause the Supplemental Claims API v0 and the Decision Reviews
API v2 to start using v3 of the the Supplemental Claim form PDF when
submitting a claim.

4153deb API-22458-update-v2-healthchecks (#11850)

• Needs cleanup, but it works

• Cleanup comments, etc

• cleanup

• Working on test. Switching branches

• Adds new tests

a315845 Api 24720 validation consolidation (#11975)

• WIP

• Removes req to always have an ssn

• Fix exception message

• Incremental commit

• Finalize error return, update tests

• Remove unused code

• Refactor bgs type logic

• Refactor validation, add test for ssn with separators

• Add missing close quote

• Remove duplicate context in test

• Remove redundant check

• Change to use unless

• Fix merge issue with duplicate method

---

Co-authored-by: Jennica Stiehl 25069483+stiehlrod@users.noreply.github.com

vets-api/v0.0.1375

Release 0.0.1375 ami-0747ea83438f0dc27

8c58e06 [11862] Setting vsp_environment values for localhost and test environments (#11933)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io

0517c5b fix failing tests (#11968)

869dae9 require 'i18n' in file (#11967)

64ae52d [11890] Dropping table VirtualAgentUserAccessRecord (#11932)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io

674256a API-23731 remove /v0/mvi-user items (#11941)

• rm v0/mvi_user items

• rm v0/mvi_user items

• rm v0/mvi_user items

ebe4b4f [11935] Making ClientConfig usage during sign in service authentication more consistent (#11946)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io

fd759a9 add logging to RX endpoints (#11913)

24d114c fix spec failures (#11970)

6958800 API-24371-valid-ssn (#11899)

• WIP

• Removes req to always have an ssn

• Fix exception message

• Incremental commit

• Finalize error return, update tests

• Remove unused code

---

Co-authored-by: Matt Christianson matthew.christianson1@va.gov

6efe679 Trying to update schema (#11952)

17ab064 forms_api: add central mail stamp and cleanup (#11966)

• add central mail stamp

• create mapper for formid

f151de9 Add prefill for form 26-4555 Adapted housing (#11976)

• enable prefill for form 26_4555

• lint

• fix test

19ec69b forms_api 26-4555 fix name mappings (#11977)

• fix name mappings

• add suffix to signature

• fix lint issue

0f86aaa Configure fields and data for HLR form v3 (#11960)

Adds blank form, fields, and data for the new version 3 of the
Higher-Level Review form. This is part 1 of 2 - it does not change any
API behavior yet.

Version 3 of this form is mostly the same as version 2 except for a few
aspects, none of which were deemed imporatant enough to warrant a new
version of the HLR API itself:

1. Removal of the SOC/SSOC review checkbox - soon, it will no longer be
   possible to opt out of this process, so the option will be considered
   true by default
2. A few minor spacing changes

2ace41a Bump pg from 1.4.5 to 1.4.6 (#11903)

Bumps pg from 1.4.5 to 1.4.6.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: pg
  dependency-type: direct:production
  update-type: version-update:semver-patch
  ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

22348fb rm stale readme (#11978)

vets-api/v0.0.1374

Release 0.0.1374 ami-0f653d7e0fd3cba85

a1141f4 Ruby 3 KwArgs: fix emis_redis spec (#11955)

• fix emis_redis spec

• clean up

• fix var name

2d82cfc Extract form_id/factory using values_at rather than kw args (#11920)

Resolves error:

ArgumentError:
  missing keywords: :form_id, :factory

a2db775 Use 16 core GHA runners (#11948)

720f5c7 Ruby 3: KwArgs fix for CareGiversAssistanceClaimSpec (#11929)

3cdca20 [EVSS to Lighthouse] Set up client credentials alternative (#11537)

• Add wrapping service for Benefits Claims API

f371b42 Vfep 281 - remove addtitional benefits section from 5490 spool file (#11958)

• remove addtl benefits from 5490 spool file

• fix gemfile.lock

60b89d8 4723 update military info service connections from emis to va profile (#11961)

• changed service connection from emis to vet360

• fixed user_request_specs

ba5285d Added new statds metric to track appeals rx email notifications (#11949)

• Added new statds metric to track appeals rx email notifications to claimant
• added claimant type statsd dimension

---

Co-authored-by: michelpmcdonald michel.mcdonald@adhocteam

vets-api/v0.0.1373

Release 0.0.1373 ami-0bba2b94990e6e387

7f7b142 API-22649-new-526-endpoints (#11938)

13ae813 Lighthouse direct deposit (#11896)

• Add direct deposit service and specs

• Remove PUT specs to keep PR under 500 lines.

c6b51e3 Add api and worker namespaces to UAVC StatsD keys (#11942)

8944c00 Api 24397 faraday bgs ssn (#11943)

• local bgs service to check for file_number

• rename method for tests

• enable check for specs

• corrections

8a285a3 53958 CHIP client initiate_check_in method (#11940)

48d7273 API-24442-consent-addr-change (#11939)

• API-24442-consent-addr-change

• passes in poa_id, and logs everytime a consent to change address occurs

b265811 Add duration logging to LocalBGS service (#11947)

• Add duration logging to LocalBGS service

61c4394 API-22858: Add supplemental claim form v3 fields and data (part 1) (#11866)

• Add Supplemental Claims form v3

• Consider appellant phone w/no country code domestic

Previously, if an AppealsApi::Appellant had a phone number without a
country code, it would be considered international. This change instead
assumes that a phone number with no country code is domestic.

• Configure fields, data for Supplemental Claim form v3

6b34bf0 Capture Type of Care, Provider's Info in Loki - update (#11944)

• updated type of care and provider logging

11a867d API-23874 Track SC evidenceType on records (#11787)

868a634 Changes description to include new status of 'canceled'. (#11950)

994cd9f Api 24364 improve validation for survivor (#11898)

• Fix logic to check claimant vs vet ssn

• Update test to correct HTTP code returned

• Fix Rubocop line length, add rswag entry for 422

• Remove byebug

• Changes to 422 test for v2

• Going with Rubocop correction

• Remove optional participant_claimant_id param

• Update docs for param removal

• Generated swagger reflecting param removal

• Commit tested version of validator

• Fix test per new validation

• Add test for updated survivor validation

• Update test user and setup to return 422 with uddated logic

• Update validate to return 422 if no claimantSsn provided for survivor type

vets-api/v0.0.1372

Release 0.0.1372 ami-0dcc377a115a26b9a

9e88e51 API-24495-add-email-recip (#11910)

• Adds tracked items status to oas

• Adds email recip

a5cbf5a Adds tracked items status to oas (#11909)

fe74a9b Corrects canceled spelling in mapper, oas docs, and schemas (#11908)

b9c3cbf [11861] Converting Sign in Service client config to use database entries rather than hard coded configs (#11901)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io

cc8e417 Profile/add derrick as toggle admin (#11927)

• add Derrick to flipper admins

• undo auto formatting yml

3ef7b9d add toggle (#11925)

bb453ae Ignore Ruby 2.7 EOL from Brakeman (#11936)

0b3b861 remove old feature toggles (#11926)

1572655 Update params (#11934)

6caae70 Ruby 3 KwArgs: PDF Fill Va21p527ez spec (#11937)

13151c7 Ruby 3 KwArgs: Various Raven-related specs (#11931)

• Ruby 3 KwArgs: Profile Parser spec

• Ruby 3 KwArgs: BB Client spec

• Ruby 3 KwArgs: PSSG Download spec

• Ruby 3 KwArgs: EVSS::FailedClaimsReport spec

• Ruby 3 KwArgs: ApplicationController spec

• Ruby 3 KwArgs: VaProfile Contact Info Service spec

a1a9427 Ruby 3 Upgrade - Handle various keyword arg/params deprecation_toolkit warnings (#11905)

• update rspec and rspec-mocks

• wip - fix keyword arg / param deprecations

• wip - clean up previous commit

• wip - fix deprecation warnings

• wip - fix deprecation warnings

• wip

• revert changes to spec_helper

• wip

• fix raising SAML::UserAttributeError

• revert change to Form1010cg::Auditor#record

• add double splat to hash in call

• rubocop

• revert changes to SignIn::Errors::StandardError#initialize

• revert changes to SAML::UserAttributeError#initialize

• rename struct var

• rename struct var

• revert changes to lib/saml/user_attributes/ssoe.rb for Trevor

• handle Eric's comments

• remove line break

• clean up

• clean up

d263f8a [11890] Removing VirtualAgentUserAccessRecord model, as it is currently unused (#11914)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io

vets-api/v0.0.1371

Release 0.0.1371 ami-090a158cb49ac47db

677bf7c 53789 feature toggle for organic login adoption (#11879)

• Add devs to flipper admin list

• Add feature flag for organic login adoption experiment

8a3c58d [35053] UserIdentity vs MPI ID Validations (#11646)

• initial commit

• adds edipi validation and updates specs

• adds icn & participant_id validations

• adds mhv correlation id validation

• fixes rails logger warn issue

• post UserIdentity refactor merge conflict fixes

• spec refactor

• rubocop fix

• refactor

• moves id_mismatch_validations to after_login_actions services

daf86f6 Ruby 3 KwArg: Form526 Convert to PDF (#11915)

Ruby 2.7 deprecated automatic casting of a hash passed as the last
argument of a method to keyword arguments. You must now use actual
keyword arguments (foo(bar: 'baz') instead of foo({bar: 'baz'})) or cast the hash to a keyword args using the double splat (foo(**{bar: 'baz'})).

In preparation for upgrading to Ruby 3.0, we're implementing the new syntax.

df6a060 VaNotify - Add confirmation email to 1990 (#11900)

85ac18e GHA: Set 20 minute timeout for Test job (#11911)

For some reason, Rspec under Ruby 3.0 is taking the max job run time (6
hours). Our jobs should complete in 5-10 minutes. This sets a sane
timeout for our test run.

200aebb HCA Validations: Also pass kwargs (#11917)

7abba61 Update rspec and related rspec gems

33449b3 Downgrade Rack to fix tests

27bac85 Fix passing message to exceptions via raise (#11919)

395091a Fix sign in controller spec (kwarg) (#11916)

b208852 add file_number toggle (#11921)

vets-api/v0.0.1370

Release 0.0.1370 ami-07d43956e7fbe474d

038d59e Remove unneeded feature flags (#11876)

b146589 [11861] Creating schema for client_config table for Sign in Service authentication (#11875)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io

95e5c23 Update UserAcceptableVerifiedCredentialCountsJob to use StatsD (#11780)

• start adding statsD keys

• first pass

• Update UserAcceptableVerifiedCredentialCountsJob to use StatsD

• cleanup specs

• Add decreased for dslogon, mhv. cleanup and add specs

• cleanup

• update to just send totals

• init uavc increment keys

• update spec

275e8e0 VAOS Appointment Service Category Logging (#11869)

*service category logging

4d7c6bf 4824 update gender identity values (#11849)

• updated gender identity values in GI schema

• updated gender identity values in VAProfile models

• updated gender identity models specs

• updated GI models specs

• regenerated docs

7bb5376 Api 24421 remove participant claimant (#11871)

• Fix logic to check claimant vs vet ssn

• Update test to correct HTTP code returned

• Fix Rubocop line length, add rswag entry for 422

• Remove byebug

• Changes to 422 test for v2

• Going with Rubocop correction

• Remove optional participant_claimant_id param

• Update docs for param removal

• Generated swagger reflecting param removal

6716996 API-24372-fix-curl-for-oas (#11893)

• Fixes OAS curl command

• Adds example for post itf

• adds swagger dev changes

833d8bd API-21586-v2-oas-updates (#11894)

• Changes descriptions for OAS

• Adds swagger file.

12e7833 Update log metrics uploader for Ruby 3.0 (#11907)

vets-api/v0.0.1369

Release 0.0.1369 ami-0935dfdd48b539b43

3ea1e53 API-24296: Remove Legacy Appeals ICN feature flag and update prod docs (#11843)

1323eae bump bgs_ext gem (#11886)

0ab37b9 GHA: Resolve some deprecation warnings (#11885)

• GHA: Update checkout action (Uses Node 16 instead of 12)

• GHA: Test result publisher updated to v2

e962553 4700: handle nil filters (#11874)

3cec4f4 Remove BigQuery from TUD (#11887)

No longer used.

1c4f0e1 update appointment date range (#11883)

8d99207 RuboCop: Fix warning for Capybara namespace (#11891)

a3e13d8 GHA: Use native RuboCop annotation format (#11888)

• Use native GHA annotations from RuboCop

• Add rc violation for testing

• Remove test rc violation

• Use GHA format for brakeman

• Update brakeman.ignore (remove obsolete ignores)

• Testing brakeman

• Revert "Testing brakeman"

This reverts commit 36b73ee9d23e5d824e3b813dff5e7d5741160af7.

• GHA: Run on ubuntu-8-cores-latest

9d0257f Created new flags for MEB landing page redirect and benefits selection logic (#11889)

Co-authored-by: fer.boza fernando.boza@accenturefederal.com

6e8fb1d Bump strong_migrations from 1.4.2 to 1.4.3 (#11877)

Bumps strong_migrations from 1.4.2 to 1.4.3.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: strong_migrations
  dependency-type: direct:production
  update-type: version-update:semver-patch
  ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

96f0cd1 Bump google-protobuf from 3.21.12 to 3.22.0 (#11878)

Bumps google-protobuf from 3.21.12 to 3.22.0.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: google-protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
  ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

f1a39f0 MHV-41829: Adjustments made to thread api (#11831)

• MHV-41829: Adjustments made to thread api

• MHV-41829: Thread list api query parameters changed